Update pkglist.awk #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Made:
Functions Created:
process_file: Handles file processing logic.
extract_fmri: Extracts the FMRI from a given line.
check_facet: Checks for the facet condition in the file.
print_fmri: Outputs the FMRI and facet information.
Variable Names: Improved readability by using more descriptive variable names and adding local scope where necessary.
Control Flow: The do...while loops were replaced with standard while loops to improve clarity.
Separation of Concerns: Each function is focused on a single task, making it easier to read and maintain.
This refactoring should maintain the original functionality while making the code easier to understand and modify in the future.
|
We do not accept pull requests. Please visit here: https://illumos.org/docs/contributing/gerrit/ and submit this via Gerrit, and remind the community at the illumos developer's list: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Functions Created
Four functions were introduced to modularize the logic and improve readability:
process_file: Handles file processing logic.extract_fmri: Extracts the FMRI from a given line.check_facet: Checks for the facet condition in the file.print_fmri: Outputs the FMRI and facet information.Variable Names
Descriptive variable names were introduced, and local scope was applied where necessary to enhance readability and maintainability.
Control Flow
The
do...whileloops were replaced with standardwhileloops to simplify and improve clarity.Separation of Concerns
Each function now focuses on a single responsibility, making the code easier to understand, maintain, and modify.
This refactoring preserves the original functionality while significantly improving the code’s readability and future adaptability.