Lint code and fix bugs

Author: ctrueden

src/imagej/__init__.py

@@ -1573,8 +1573,9 @@ def _guess_java_version() -> Optional[int]:
     # already-installed JVM available on the system. So let's be more
     # nuanced in how we predict the future here.
     fetch_plan = sj.config.get_fetch_java()
-    will_fetch = fetch_plan == 'always' or \
-        (fetch_rule == 'auto' and version_digits is None)
+    will_fetch = fetch_plan == "always" or (
+        fetch_plan == "auto" and version_digits is None
+    )
     if will_fetch:
         version_to_fetch = sj.config.get_java_version()
         _logger.debug(f"Detected Java version to fetch: {version_to_fetch}")
@@ -1647,7 +1648,7 @@ def _prepare_to_unlock_modules() -> bool:
 
     if major_version is not None and major_version >= 9:
         # Allow illegal reflection access. Necessary for Java 17+.
-        option = f"--add-opens=java.base/java.lang=ALL-UNNAMED"
+        option = "--add-opens=java.base/java.lang=ALL-UNNAMED"
         _logger.debug(f"Adding option: {option}")
         sj.config.add_option(option)
         return True

src/imagej/_java.py

@@ -29,21 +29,24 @@ def unlock_modules(logger: logging.Logger) -> None:
         Module = jimport("java.lang.Module")
         ModuleLayer = jimport("java.lang.ModuleLayer")
         String = jimport("java.lang.String")
-        Method = jimport("java.lang.reflect.Method")
 
-        addOpens = Module.class_.getDeclaredMethod("implAddOpens", String.class_, Module.class_)
+        addOpens = Module.class_.getDeclaredMethod(
+            "implAddOpens", String.class_, Module.class_
+        )
         addOpens.setAccessible(True)
-        addExports = Module.class_.getDeclaredMethod("implAddExports", String.class_, Module.class_)
+        addExports = Module.class_.getDeclaredMethod(
+            "implAddExports", String.class_, Module.class_
+        )
         addExports.setAccessible(True)
 
         # HACK: We need a class from the unnamed module.
         unnamed = jimport("org.scijava.Context").class_.getModule()
 
         for module in ModuleLayer.boot().modules():
-            for package in m.getPackages():
+            for package in module.getPackages():
                 try:
-                    addOpens.invoke(m, package, unnamed)
-                    addExports.invoke(m, package, unnamed)
+                    addOpens.invoke(module, package, unnamed)
+                    addExports.invoke(module, package, unnamed)
                 except Exception as e:
                     # Continue with other packages
                     log_exception(logger, e)

tests/test_callbacks.py

@@ -1,5 +1,6 @@
 from scyjava import jimport
 
+
 def test_when_imagej_starts(ij):
     """
     The ImageJ2 gateway test fixture registers a callback function via