-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Describe the bug
When commits that bump dependencies (like 802d759) are made to main
, we expect Release Please to automatically create or update a Release PR. This doesn't happen.
To reproduce
- Merge a Dependabot PR
Expected behaviour
A Release Please-managed Release PR to be updated (including CHANGELOG.md
), or, if there is no currently active Release PR, to be created with a semver-patch version bump.
Screenshots
No response
Desktop (please complete the following information)
No response
Mobile (please complete the following information)
No response
Additional context
How the release process works
The release process has 2 parts:
- conventional commit syntax is enforced
- release-please-action manages release creation
What conventional commit syntax means
Conventional commit syntax is a standard way of writing commit messages. It helps automated tools understand what type of change you've made.
How Release Please creates releases
Release Please creates releases when it finds a 'releasable unit' in your commit history. A releasable unit is:
feat:
(increases the minor version number)fix:
(increases the patch version number)deps:
(increases the patch version number)- any breaking change (increases the major version number)
The problem with dependency commits
The deps:
commit type is not part of the conventional commit specification. This means commitlint needs extra configuration to support it.
What we can do
We have 3 options:
- use Renovate instead of Dependabot - Renovate supports the correct commit format
- use a different tool than Release Please to create GitHub releases
- do not enforce a specific way to create releases