feat: relax CAR tests to accept both 200 and 404 for non-existing paths #244
+57
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response code for non-existing paths now depends on implementation details such as locality and cost of path traversal checks. - Implementations that can efficiently detect non-existing paths should return 404 Not Found (improved behavior per ipfs/boxo#458) - Implementations focusing on stateless streaming and low latency may return 200 with partial CAR up to the missing link (legacy behavior) This change: - Updates TestTrustlessCarPathing to use AnyOf for non-existing file test - Enhances applyStandardCarResponseHeaders to handle AnyOfExpectBuilder - Applies CAR headers only to 200 responses, not to error responses - Refactors helper code to be more DRY and idiomatic
|
Results against Kubo master: Summary
|
|
Results against Kubo latest: Summary
|
Includes relaxed CAR tests that accept both 200 and 404 for non-existing paths. See #244 for details.
v0.8.2Changed
|
|
Shipping as this is backward-compatible patch that does not require any changes in existing software, but unblocks us to work on ipfs/boxo#458 & ipfs/boxo#1019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response code for non-existing paths now depends on implementation details such as locality and cost of path traversal checks.
This change: