Fix an NPE caused by setting things up in the wrong order.

Author: iso2013

API/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <artifactId>PacketEntityAPI</artifactId>
         <groupId>net.blitzcube.peapi</groupId>
-        <version>0.4.2-SNAPSHOT</version>
+        <version>0.4.3-SNAPSHOT</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

Plugin/pom.xml

@@ -6,7 +6,7 @@
     <parent>
         <artifactId>PacketEntityAPI</artifactId>
         <groupId>net.blitzcube.peapi</groupId>
-        <version>0.4.2-SNAPSHOT</version>
+        <version>0.4.3-SNAPSHOT</version>
     </parent>
 
     <artifactId>Plugin</artifactId>
@@ -59,7 +59,7 @@
         <dependency>
             <groupId>net.blitzcube.peapi</groupId>
             <artifactId>API</artifactId>
-            <version>0.4.2-SNAPSHOT</version>
+            <version>0.4.3-SNAPSHOT</version>
         </dependency>
     </dependencies>
 </project>

Plugin/src/main/java/net/blitzcube/peapi/event/engine/PacketEventDispatcher.java

@@ -33,14 +33,6 @@ public PacketEventDispatcher(PacketEntityAPI parent, ProtocolManager manager) {
 
     public void add(IListener l) {
         this.allListeners.add(l);
-        if (l.shouldFireForFake()) {
-            if (sendingForFake == 0) engine.setSendForFake(true);
-            sendingForFake++;
-        }
-        if (l.requiresCollidable()) {
-            if (requiresCollidable == 0) engine.setCollidable(true);
-            requiresCollidable++;
-        }
         boolean e = false, o = false;
         for (EntityType en : l.getTargets()) {
             listenerLookup.putIfAbsent(en, new TreeSet<>(LISTENER_COMPARATOR));
@@ -62,6 +54,14 @@ public void add(IListener l) {
             targetingEntities++;
             entityListeners.add(l);
         }
+        if (l.shouldFireForFake()) {
+            if (sendingForFake == 0) engine.setSendForFake(true);
+            sendingForFake++;
+        }
+        if (l.requiresCollidable()) {
+            if (requiresCollidable == 0) engine.setCollidable(true);
+            requiresCollidable++;
+        }
     }
 
     public void dispatch(IEntityPacketEvent e, Boolean object) {

Plugin/src/main/java/net/blitzcube/peapi/event/engine/PacketEventEngine.java

@@ -24,9 +24,9 @@ class PacketEventEngine {
     }
 
     void setSendForFake(boolean sendForFake) {
-        entity.setSendForFake(sendForFake);
-        generic.setSendForFake(sendForFake);
-        object.setSendForFake(sendForFake);
+        if (entity != null) entity.setSendForFake(sendForFake);
+        if (generic != null) generic.setSendForFake(sendForFake);
+        if (object != null) object.setSendForFake(sendForFake);
     }
 
     void setCollidable(boolean collidable) {

pom.xml

@@ -7,7 +7,7 @@
     <groupId>net.blitzcube.peapi</groupId>
     <artifactId>PacketEntityAPI</artifactId>
     <packaging>pom</packaging>
-    <version>0.4.2-SNAPSHOT</version>
+    <version>0.4.3-SNAPSHOT</version>
     <modules>
         <module>API</module>
         <module>Plugin</module>