Skip to content

Conversation

@itinycheng
Copy link
Owner

Why are the changes needed?

Close #156.

Brief change log

  • Trigger the data flush method during checkpoint.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Copy link
Collaborator

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czy006 czy006 merged commit 5f879c6 into master Dec 15, 2024
2 checks passed
therealhieu pushed a commit to therealhieu/flink-connector-clickhouse that referenced this pull request Aug 22, 2025
[fix]: Ensure checkpointing triggers records flush to ClickHouse itinycheng#156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Checkpointing doesn't trigger records flush to clickhouse

3 participants