Skip to content

Commit 1bf3fd5

Browse files
authored
fix: default won't overwrite editor's value (#200)
1 parent 6b30745 commit 1bf3fd5

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@
7777
"remote.SSH.serverDownloadUrlTemplate": {
7878
"type": "string",
7979
"description": "The URL from where the vscode server will be downloaded. You can use the following variables and they will be replaced dynamically:\n- ${quality}: vscode server quality, e.g. stable or insiders\n- ${version}: vscode server version, e.g. 1.69.0\n- ${commit}: vscode server release commit\n- ${arch}: vscode server arch, e.g. x64, armhf, arm64\n- ${release}: release number, vscodium only https://github.com/VSCodium/vscodium/pull/1192",
80-
"scope": "application",
81-
"default": "https://github.com/VSCodium/vscodium/releases/download/${version}.${release}/vscodium-reh-${os}-${arch}-${version}.${release}.tar.gz"
80+
"scope": "application"
8281
},
8382
"remote.SSH.remotePlatform": {
8483
"type": "object",

src/serverSetup.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export async function installCodeServer(conn: SSHConnection, serverDownloadUrlTe
8181
useSocketPath,
8282
serverApplicationName: vscodeServerConfig.serverApplicationName,
8383
serverDataFolderName: vscodeServerConfig.serverDataFolderName,
84-
serverDownloadUrlTemplate: serverDownloadUrlTemplate ?? vscodeServerConfig.serverDownloadUrlTemplate ?? DEFAULT_DOWNLOAD_URL_TEMPLATE,
84+
serverDownloadUrlTemplate: serverDownloadUrlTemplate || vscodeServerConfig.serverDownloadUrlTemplate || DEFAULT_DOWNLOAD_URL_TEMPLATE,
8585
};
8686

8787
let commandOutput: { stdout: string; stderr: string };

0 commit comments

Comments
 (0)