Correct a failing unit test.

jeremydumais · jeremydumais · commit 1f2d46b996fb · 2022-02-06T08:25:10.000-05:00
diff --git a/src/smtpclientbase.cpp b/src/smtpclientbase.cpp
@@ -304,7 +304,8 @@ int SMTPClientBase::getErrorMessage_r(int errorCode,
         return -1;
     }
     if (errorMessageStr.length() > maxLength-1) {
-        strcpy(errorMessagePtr, errorMessageStr.c_str());
+        strncpy(errorMessagePtr, errorMessageStr.c_str(), maxLength-1);
+        errorMessagePtr[maxLength-1] = '\0';
         return static_cast<int>(maxLength-1);
     }
     strcpy(errorMessagePtr, errorMessageStr.c_str());

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,8 @@ int SMTPClientBase::getErrorMessage_r(int errorCode,`
`304`	`304`	`return -1;`
`305`	`305`	`}`
`306`	`306`	`if (errorMessageStr.length() > maxLength-1) {`
`307`		`- strcpy(errorMessagePtr, errorMessageStr.c_str());`
	`307`	`+ strncpy(errorMessagePtr, errorMessageStr.c_str(), maxLength-1);`
	`308`	`+ errorMessagePtr[maxLength-1] = '\0';`
`308`	`309`	`return static_cast<int>(maxLength-1);`
`309`	`310`	`}`
`310`	`311`	`strcpy(errorMessagePtr, errorMessageStr.c_str());`