Revert "feat(compiler-cli): detect missing structural directive imports (angular#59443)" (angular#59544)

This reverts commit ed705a8.

PR Close angular#59544

Author: AndrewKushnir

adev/src/content/reference/extended-diagnostics/NG8114.md

@@ -20,8 +20,7 @@ Currently, Angular supports the following extended diagnostics:
 | `NG8108` | [`skipHydrationNotStatic`](extended-diagnostics/NG8108)          |
 | `NG8109` | [`interpolatedSignalNotInvoked`](extended-diagnostics/NG8109)    |
 | `NG8111` | [`uninvokedFunctionInEventBinding`](extended-diagnostics/NG8111) |
-| `NG8113` | [`unusedStandaloneImports`](extended-diagnostics/NG8113)         |
-| `NG8114` | [`missingStructuralDirective`](extended-diagnostics/NG8114)      |
+| `NG8113` | [`unusedStandaloneImports`](extended-diagnostics/NG8113) |
 
 ## Configuration
 

adev/src/content/reference/extended-diagnostics/overview.md

@@ -75,7 +75,6 @@ export enum ErrorCode {
     MISSING_PIPE = 8004,
     MISSING_REFERENCE_TARGET = 8003,
     MISSING_REQUIRED_INPUTS = 8008,
-    MISSING_STRUCTURAL_DIRECTIVE = 8114,
     NGMODULE_BOOTSTRAP_IS_STANDALONE = 6009,
     NGMODULE_DECLARATION_IS_STANDALONE = 6008,
     NGMODULE_DECLARATION_NOT_UNIQUE = 6007,

goldens/public-api/compiler-cli/error_code.api.md

@@ -17,8 +17,6 @@ export enum ExtendedTemplateDiagnosticName {
     // (undocumented)
     MISSING_NGFOROF_LET = "missingNgForOfLet",
     // (undocumented)
-    MISSING_STRUCTURAL_DIRECTIVE = "missingStructuralDirective",
-    // (undocumented)
     NULLISH_COALESCING_NOT_NULLABLE = "nullishCoalescingNotNullable",
     // (undocumented)
     OPTIONAL_CHAIN_NOT_NULLABLE = "optionalChainNotNullable",

goldens/public-api/compiler-cli/extended_template_diagnostic_name.api.md

@@ -518,11 +518,6 @@ export enum ErrorCode {
    */
   UNUSED_STANDALONE_IMPORTS = 8113,
 
-  /**
-   * A structural directive is used in a template, but the directive is not imported.
-   */
-  MISSING_STRUCTURAL_DIRECTIVE = 8114,
-
   /**
    * The template type-checking engine would need to generate an inline type check block for a
    * component, but the current type-checking environment doesn't support it.

packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts

@@ -20,7 +20,6 @@ export enum ExtendedTemplateDiagnosticName {
   NULLISH_COALESCING_NOT_NULLABLE = 'nullishCoalescingNotNullable',
   OPTIONAL_CHAIN_NOT_NULLABLE = 'optionalChainNotNullable',
   MISSING_CONTROL_FLOW_DIRECTIVE = 'missingControlFlowDirective',
-  MISSING_STRUCTURAL_DIRECTIVE = 'missingStructuralDirective',
   TEXT_ATTRIBUTE_NOT_BINDING = 'textAttributeNotBinding',
   UNINVOKED_FUNCTION_IN_EVENT_BINDING = 'uninvokedFunctionInEventBinding',
   MISSING_NGFOROF_LET = 'missingNgForOfLet',

packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts

@@ -16,7 +16,6 @@ ts_library(
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/invalid_banana_in_box",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_ngforof_let",
-        "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_structural_directive",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/nullish_coalescing_not_nullable",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/optional_chain_not_nullable",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/skip_hydration_not_static",

packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel

@@ -13,7 +13,6 @@ import {factory as interpolatedSignalNotInvoked} from './checks/interpolated_sig
 import {factory as invalidBananaInBoxFactory} from './checks/invalid_banana_in_box';
 import {factory as missingControlFlowDirectiveFactory} from './checks/missing_control_flow_directive';
 import {factory as missingNgForOfLetFactory} from './checks/missing_ngforof_let';
-import {factory as missingStructuralDirectiveFactory} from './checks/missing_structural_directive';
 import {factory as nullishCoalescingNotNullableFactory} from './checks/nullish_coalescing_not_nullable';
 import {factory as optionalChainNotNullableFactory} from './checks/optional_chain_not_nullable';
 import {factory as suffixNotSupportedFactory} from './checks/suffix_not_supported';
@@ -33,7 +32,6 @@ export const ALL_DIAGNOSTIC_FACTORIES: readonly TemplateCheckFactory<
   missingControlFlowDirectiveFactory,
   textAttributeNotBindingFactory,
   missingNgForOfLetFactory,
-  missingStructuralDirectiveFactory,
   suffixNotSupportedFactory,
   interpolatedSignalNotInvoked,
   uninvokedFunctionInEventBindingFactory,