Skip to content

Commit 94efe29

Browse files
committed
Revert "Cache name-hashes in a static var, makes subsequent calls much faster"
This reverts commit e11abf2.
1 parent 4e7383a commit 94efe29

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

MapDataReader/MapperGenerator.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,22 +70,19 @@ private static void SetPropertyByName(this {typeNodeSymbol.FullName()} target, i
7070
if (typeNodeSymbol.InstanceConstructors.Any(c => !c.Parameters.Any())) //has a constructor without parameters?
7171
{
7272
src += $@"
73-
private static int[] _columnNameHashes{typeNode.Identifier} = null;
7473
7574
public static List<{typeNodeSymbol.FullName()}> To{typeNode.Identifier}(this IDataReader dr)
7675
{{
7776
var list = new List<{typeNodeSymbol.FullName()}>();
7877
7978
if (dr.Read())
8079
{{
81-
if(_columnNameHashes{typeNode.Identifier} == null)
82-
_columnNameHashes{typeNode.Identifier} = Enumerable.Range(0, dr.FieldCount).Select(i => MapperGenerator.GetDeterministicHashCode(dr.GetName(i))).ToArray();
83-
80+
int[] columnNameHashes = Enumerable.Range(0, dr.FieldCount).Select(i => MapperGenerator.GetDeterministicHashCode(dr.GetName(i))).ToArray();
8481
do
8582
{{
8683
var result = new {typeNodeSymbol.FullName()}();
8784
int i = 0;
88-
foreach (var col in _columnNameHashes{typeNode.Identifier})
85+
foreach (var col in columnNameHashes)
8986
{{
9087
var value = dr[i];
9188
if (value is DBNull) value = null;

0 commit comments

Comments
 (0)