fix: improve CLI validation and code organization

- Move document categories and locations to shared constants file
- Add URL validation for --url option using URI parsing
- Add ISO 8601 date validation for --published-date option
- Add comprehensive tests for new validation features
- Add .rspec_status to gitignore

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: joshbeckman

.gitignore

@@ -55,3 +55,5 @@ Gemfile.lock
 
 # Used by RuboCop. Remote config files pulled in from inherit_from directive.
 # .rubocop-https?--*
+
+.rspec_status

lib/readwise/cli/document/create_command.rb

@@ -1,10 +1,12 @@
 require_relative '../base_command'
+require_relative '../../constants'
+require 'uri'
+require 'date'
 
 module Readwise
   class CLI
     module Document
       class CreateCommand < BaseCommand
-        CATEGORIES = %w[article email rss highlight note pdf epub tweet video].freeze
         def banner
           "Usage: readwise document create [options]"
         end
@@ -27,6 +29,10 @@ def add_options(opts)
           end
 
           opts.on("-u", "--url=URL", "Source URL (defaults to https://example.com/<filename>)") do |url|
+            unless valid_url?(url)
+              puts "Error: Invalid URL format. Please provide a valid URL."
+              exit 1
+            end
             options[:url] = url
           end
 
@@ -38,17 +44,17 @@ def add_options(opts)
             options[:notes] = notes
           end
 
-          opts.on("--location=LOCATION", "Document location: new, later, archive, feed (default: new)") do |location|
-            unless %w[new later archive feed].include?(location)
-              puts "Error: Invalid location. Must be one of: new, later, archive, feed"
+          opts.on("--location=LOCATION", "Document location: #{Readwise::Constants::DOCUMENT_LOCATIONS.join(', ')} (default: new)") do |location|
+            unless Readwise::Constants::DOCUMENT_LOCATIONS.include?(location)
+              puts "Error: Invalid location. Must be one of: #{Readwise::Constants::DOCUMENT_LOCATIONS.join(', ')}"
               exit 1
             end
             options[:location] = location
           end
 
-          opts.on("--category=CATEGORY", "Document category: #{CATEGORIES.join(', ')}") do |category|
-            unless CATEGORIES.include?(category)
-              puts "Error: Invalid category. Must be one of: #{CATEGORIES.join(', ')}"
+          opts.on("--category=CATEGORY", "Document category: #{Readwise::Constants::DOCUMENT_CATEGORIES.join(', ')}") do |category|
+            unless Readwise::Constants::DOCUMENT_CATEGORIES.include?(category)
+              puts "Error: Invalid category. Must be one of: #{Readwise::Constants::DOCUMENT_CATEGORIES.join(', ')}"
               exit 1
             end
             options[:category] = category
@@ -63,6 +69,10 @@ def add_options(opts)
           end
 
           opts.on("--published-date=DATE", "Published date (ISO 8601 format)") do |date|
+            unless valid_iso8601_date?(date)
+              puts "Error: Invalid date format. Please provide a valid ISO 8601 date (e.g., 2023-12-25T10:30:00Z)."
+              exit 1
+            end
             options[:published_date] = date
           end
 
@@ -104,6 +114,20 @@ def run(args)
 
         private
 
+        def valid_url?(url)
+          uri = URI.parse(url)
+          uri.is_a?(URI::HTTP) || uri.is_a?(URI::HTTPS)
+        rescue URI::InvalidURIError
+          false
+        end
+
+        def valid_iso8601_date?(date)
+          DateTime.iso8601(date)
+          true
+        rescue Date::Error
+          false
+        end
+
         def build_document_params(html_content, html_file)
           document_params = {
             html: html_content,

lib/readwise/constants.rb

@@ -0,0 +1,6 @@
+module Readwise
+  module Constants
+    DOCUMENT_CATEGORIES = %w[article email rss highlight note pdf epub tweet video].freeze
+    DOCUMENT_LOCATIONS = %w[new later archive feed].freeze
+  end
+end

spec/cli_spec.rb

@@ -100,5 +100,19 @@ def run_cli_without_token(*args)
       expect(status.success?).to be false
       expect(stdout).to include('Error: Invalid category. Must be one of: article, email, rss, highlight, note, pdf, epub, tweet, video')
     end
+
+    it 'shows error for invalid URL' do
+      stdout, _stderr, status = run_cli('document', 'create', '--url=invalid-url', '--html-file', temp_file.path)
+
+      expect(status.success?).to be false
+      expect(stdout).to include('Error: Invalid URL format. Please provide a valid URL.')
+    end
+
+    it 'shows error for invalid date format' do
+      stdout, _stderr, status = run_cli('document', 'create', '--published-date=invalid-date', '--html-file', temp_file.path)
+
+      expect(status.success?).to be false
+      expect(stdout).to include('Error: Invalid date format. Please provide a valid ISO 8601 date')
+    end
   end
 end