Fix link issue with ZLib

Thomas-Barbier-1A · Thomas-Barbier-1A · commit 26c4ebe33e89 · 2018-02-20T17:00:04.000+01:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -12,6 +12,7 @@ endif()
 
 find_package(GoogleBenchmark)
 find_package(Protobuf REQUIRED)
+find_package(ZLIB REQUIRED)
 find_package(Telegraf)
 
 # suppress warnings
diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt
@@ -42,7 +42,7 @@ add_library(prometheus-cpp
 )
 
 # TODO(gj) make all PRIVATE
-target_link_libraries(prometheus-cpp PUBLIC ${PROTOBUF_LIBRARIES})
+target_link_libraries(prometheus-cpp PUBLIC ${PROTOBUF_LIBRARIES} ${ZLIB_LIBRARIES} )
 target_include_directories(prometheus-cpp PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>)
 target_include_directories(prometheus-cpp PUBLIC ${PROTOBUF_INCLUDE_DIRS})
 target_include_directories(prometheus-cpp PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>)

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ add_library(prometheus-cpp`
`42`	`42`	`)`
`43`	`43`
`44`	`44`	`# TODO(gj) make all PRIVATE`
`45`		`-target_link_libraries(prometheus-cpp PUBLIC ${PROTOBUF_LIBRARIES})`
	`45`	`+target_link_libraries(prometheus-cpp PUBLIC ${PROTOBUF_LIBRARIES} ${ZLIB_LIBRARIES} )`
`46`	`46`	`target_include_directories(prometheus-cpp PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>)`
`47`	`47`	`target_include_directories(prometheus-cpp PUBLIC ${PROTOBUF_INCLUDE_DIRS})`
`48`	`48`	`target_include_directories(prometheus-cpp PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>)`