Merge pull request #59 from jupp0r/feature/remove-histogram-builder-buckets

jupp0r · web-flow · commit f3d91b908f72 · 2017-04-19T22:42:13.000+02:00
Remove unused bucket option on histogram builder
diff --git a/include/prometheus/histogram_builder.h b/include/prometheus/histogram_builder.h
@@ -23,14 +23,12 @@ class HistogramBuilder {
   HistogramBuilder& Labels(const std::map<std::string, std::string>& labels);
   HistogramBuilder& Name(const std::string&);
   HistogramBuilder& Help(const std::string&);
-  HistogramBuilder& Buckets(const std::vector<double>&);
   Family<Histogram>& Register(Registry&);
 
  private:
   std::map<std::string, std::string> labels_;
   std::string name_;
   std::string help_;
-  std::vector<double> buckets_;
 };
 }
 }
diff --git a/lib/histogram_builder.cc b/lib/histogram_builder.cc
@@ -23,12 +23,6 @@ HistogramBuilder& HistogramBuilder::Help(const std::string& help) {
   return *this;
 }
 
-HistogramBuilder& HistogramBuilder::Buckets(
-    const std::vector<double>& buckets) {
-  buckets_ = buckets;
-  return *this;
-}
-
 Family<Histogram>& HistogramBuilder::Register(Registry& registry) {
   return registry.AddHistogram(name_, help_, labels_);
 }

Original file line number	Diff line number	Diff line change
`@@ -23,14 +23,12 @@ class HistogramBuilder {`
`23`	`23`	`HistogramBuilder& Labels(const std::map<std::string, std::string>& labels);`
`24`	`24`	`HistogramBuilder& Name(const std::string&);`
`25`	`25`	`HistogramBuilder& Help(const std::string&);`
`26`		`- HistogramBuilder& Buckets(const std::vector<double>&);`
`27`	`26`	`Family<Histogram>& Register(Registry&);`
`28`	`27`
`29`	`28`	`private:`
`30`	`29`	`std::map<std::string, std::string> labels_;`
`31`	`30`	`std::string name_;`
`32`	`31`	`std::string help_;`
`33`		`- std::vector<double> buckets_;`
`34`	`32`	`};`
`35`	`33`	`}`
`36`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,12 +23,6 @@ HistogramBuilder& HistogramBuilder::Help(const std::string& help) {`
`23`	`23`	`return *this;`
`24`	`24`	`}`
`25`	`25`
`26`		`-HistogramBuilder& HistogramBuilder::Buckets(`
`27`		`- const std::vector<double>& buckets) {`
`28`		`- buckets_ = buckets;`
`29`		`- return *this;`
`30`		`-}`
`31`		`-`
`32`	`26`	`Family<Histogram>& HistogramBuilder::Register(Registry& registry) {`
`33`	`27`	`return registry.AddHistogram(name_, help_, labels_);`
`34`	`28`	`}`