Skip to content

Missing "DisableInternalBinLog = true" in PackageTasks.fs #3

@caroott

Description

@caroott

The PackageTasks.fs has set the filed DisableInternalBinLog of MSBuildParams to false, which results in a unsupported log file format error. Changing the msBuilParams to the following fixes the error:

let msBuildParams =
    match pInfo.ReleaseNotes with
    | Some r ->
        { p.MSBuildParams with
            Properties =
                ([
                    "Version",pInfo.PackageVersionTag
                    "AssemblyVersion", pInfo.AssemblyVersion
                    "AssemblyInformationalVersion", pInfo.AssemblyVersion
                    "PackageReleaseNotes",  (r.Notes |> String.concat "\r\n")
                    "TargetsForTfmSpecificContentInPackage", "" //https://github.com/dotnet/fsharp/issues/12320
                    ]
                    @ p.MSBuildParams.Properties)
            DisableInternalBinLog = true // this line here
        }
    | _ ->
        { p.MSBuildParams with
            Properties =
                ([
                    "Version",pInfo.PackageVersionTag
                    "AssemblyVersion", pInfo.AssemblyVersion
                    "AssemblyInformationalVersion", pInfo.AssemblyVersion
                    "TargetsForTfmSpecificContentInPackage", "" //https://github.com/dotnet/fsharp/issues/12320
                    ]
                    @ p.MSBuildParams.Properties)
            DisableInternalBinLog = true // and this line here
        }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions