🚧 [WIP] 🚧 Generate GitHub actions workflow. 👷 🏗️ #3128
Draft
+15,115
−14,720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: twoGiants The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/L
twoGiants
force-pushed
the
issue-744-generate-github-actions-workflow
branch
2 times, most recently
from
edad0e7 to
2b2cc43
Compare
knative-prow
bot
added
size/XL
Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Add 'func config ci' command as foundation for GitHub Actions workflow generation. Extract function loader/saver interfaces into cmd/common package and create cmd/testing factory for reusable test helpers. Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Add functionality to create GitHub Actions workflow directory and file when running config ci command. Includes CIConfig struct for managing workflow paths and permissions, with comprehensive test coverage. Also fixes typo and refactors config tests to use helper functions. Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Signed-off-by: Stanislav Jakuschevskij <[email protected]>
- Add YAML structure types for workflow generation - Generate hard coded remote-build-and-deploy workflow with checkout, func cli setup, and deploy steps - Validate workflow structure and content in tests - Export NewCIConfig for external use Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
- Move CIConfig and workflow structs to cmd/ci package - Separate config management (config.go) and workflow generation (workflow.go) - Add CIConfig methods for path resolution - Support custom workflow names via NewDefaultCIConfigWithName - Update imports across cmd package Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
- Add TDD and implementation guidelines to CLAUDE.md - Create /creview slash command for code reviews - Update issue-744 feature doc to mark Phase 2.1 complete Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants
force-pushed
the
issue-744-generate-github-actions-workflow
branch
from
48ac762 to
c2000cd
Compare
knative-prow-robot
removed
the
needs-rebase
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
+ Coverage 62.85% 64.00% +1.14%
==========================================
Files 148 155 +7
Lines 13202 13339 +137
==========================================
+ Hits 8298 8537 +239
+ Misses 3941 3809 -132
- Partials 963 993 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add NewGithubWorkflowFromPath for loading workflows from disk - Replace AsYaml + PersistToDisk with Persist method that handles both marshalling and file operations - Rename FnGithubWorkflowYamlPath to FnGithubWorkflowFilepath - Extract test assertion logic into helper functions - Improve test readability with consistent naming and structure Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
- Add Kubernetes context setup using azure/k8s-set-context action with configurable kubeconfig secret key - Add optional container registry authentication with conditional execution - Support self-hosted runners configuration - Number workflow steps for better readability Issue SRVOCF-744 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
knative-prow-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind enhancement
Fixes #tba...
Release Note
Docs