From 3e5152edd28952aa5ca47c0fc60edaca9a598f05 Mon Sep 17 00:00:00 2001 From: mahdikhashan Date: Fri, 4 Apr 2025 18:48:51 +0200 Subject: [PATCH 1/5] push to ghcr Signed-off-by: mahdikhashan --- .../workflows/mpi-operator-docker-image-publish.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/mpi-operator-docker-image-publish.yml b/.github/workflows/mpi-operator-docker-image-publish.yml index 943dae440..d495a6c66 100644 --- a/.github/workflows/mpi-operator-docker-image-publish.yml +++ b/.github/workflows/mpi-operator-docker-image-publish.yml @@ -12,6 +12,7 @@ on: env: IMAGE_NAME: mpioperator/mpi-operator + GHCR_IMAGE_NAME: ghcr.io/mpioperator/mpi-operator jobs: build-push-docker-image: @@ -26,6 +27,7 @@ jobs: with: images: | ${{ env.IMAGE_NAME }} + ${{ env.GHCR_IMAGE_NAME }} tags: | type=ref,event=branch type=ref,event=pr @@ -39,6 +41,14 @@ jobs: username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }} + - name: Login to GitHub Container Registry + if: github.event_name != 'pull_request' + uses: docker/login-action@v2 + with: + registry: ghcr.io + username: ${{ github.actor }} + password: ${{ secrets.GITHUB_TOKEN }} + - name: Docker Setup QEMU uses: docker/setup-qemu-action@v2.1.0 From a8292da264452eea69391ab95fbfe27fd5a79a87 Mon Sep 17 00:00:00 2001 From: mahdikhashan Date: Fri, 4 Apr 2025 18:51:27 +0200 Subject: [PATCH 2/5] improve code Signed-off-by: mahdikhashan --- .github/workflows/mpi-operator-docker-image-publish.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/mpi-operator-docker-image-publish.yml b/.github/workflows/mpi-operator-docker-image-publish.yml index d495a6c66..15f8c891c 100644 --- a/.github/workflows/mpi-operator-docker-image-publish.yml +++ b/.github/workflows/mpi-operator-docker-image-publish.yml @@ -12,7 +12,6 @@ on: env: IMAGE_NAME: mpioperator/mpi-operator - GHCR_IMAGE_NAME: ghcr.io/mpioperator/mpi-operator jobs: build-push-docker-image: @@ -27,7 +26,7 @@ jobs: with: images: | ${{ env.IMAGE_NAME }} - ${{ env.GHCR_IMAGE_NAME }} + ghcr.io/${{ env.IMAGE_NAME }} tags: | type=ref,event=branch type=ref,event=pr From e2d8be25092d099074a45c88f8ff0f318e58278d Mon Sep 17 00:00:00 2001 From: mahdikhashan Date: Sat, 5 Apr 2025 10:21:38 +0200 Subject: [PATCH 3/5] hardcode ghcr image name Signed-off-by: mahdikhashan --- .github/workflows/mpi-operator-docker-image-publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/mpi-operator-docker-image-publish.yml b/.github/workflows/mpi-operator-docker-image-publish.yml index 15f8c891c..55264655a 100644 --- a/.github/workflows/mpi-operator-docker-image-publish.yml +++ b/.github/workflows/mpi-operator-docker-image-publish.yml @@ -26,7 +26,7 @@ jobs: with: images: | ${{ env.IMAGE_NAME }} - ghcr.io/${{ env.IMAGE_NAME }} + ghcr.io/kubeflow/mpi-operator/controller tags: | type=ref,event=branch type=ref,event=pr From b6045a2893996265146acc766a6e0030ade0e262 Mon Sep 17 00:00:00 2001 From: mahdikhashan Date: Mon, 14 Apr 2025 18:51:17 +0200 Subject: [PATCH 4/5] update readme with ghcr Signed-off-by: mahdikhashan --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5d710ddf2..a317dd09b 100644 --- a/README.md +++ b/README.md @@ -240,7 +240,7 @@ For example `kube_pod_info * on(pod,namespace) group_left label_replace(mpi_oper ## Docker Images -We push Docker images of [mpioperator on Dockerhub](https://hub.docker.com/u/mpioperator) for every release. +We push Docker images of [mpioperator on Github Contrainer Registry](https://github.com/orgs/kubeflow/packages?repo_name=mpi-operator) for every release. You can use the following Dockerfile to build the image yourself: - [mpi-operator](https://github.com/kubeflow/mpi-operator/blob/master/Dockerfile) From c88d4743febbdfd60da274956ed5aa83dd062d16 Mon Sep 17 00:00:00 2001 From: mahdikhashan Date: Mon, 14 Apr 2025 18:54:26 +0200 Subject: [PATCH 5/5] fix typo Signed-off-by: mahdikhashan --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a317dd09b..566dc1127 100644 --- a/README.md +++ b/README.md @@ -240,7 +240,7 @@ For example `kube_pod_info * on(pod,namespace) group_left label_replace(mpi_oper ## Docker Images -We push Docker images of [mpioperator on Github Contrainer Registry](https://github.com/orgs/kubeflow/packages?repo_name=mpi-operator) for every release. +We push Docker images of [mpioperator on Github Container Registry](https://github.com/orgs/kubeflow/packages?repo_name=mpi-operator) for every release. You can use the following Dockerfile to build the image yourself: - [mpi-operator](https://github.com/kubeflow/mpi-operator/blob/master/Dockerfile)