issue-11979 - WIP - Fixed tests

Signed-off-by: Helber Belmiro <[email protected]>

Author: hbelmiro

CONTEXT.md

@@ -721,4 +721,42 @@ func (s *TestSuite) cleanUp() {
 - `/backend/test/integration/dag_status_conditional_test.go` - Nil client checks
 - `/backend/test/integration/dag_status_parallel_for_test.go` - Nil client checks
 
-**Result**: CI-ready code with comprehensive nil pointer protection and robust error handling.
+**Result**: CI-ready code with comprehensive nil pointer protection and robust error handling.
+
+## **⚠️ Potential Side Effects - Test Behavior Changes**
+
+### **Issue: Upgrade Test Timeout After DAG Completion Fixes**
+After implementing the DAG completion fixes, the CI upgrade test (`TestUpgrade/TestPrepare`) started timing out after 10 minutes.
+
+**Timeline**: 
+- **Before DAG fixes**: Pipeline runs could show `SUCCEEDED` even with DAGs stuck in `RUNNING` state
+- **After DAG fixes**: DAGs now correctly transition to final states (`COMPLETE`/`FAILED`)
+
+**Potential Root Cause**: 
+The DAG completion fixes may have exposed test quality issues that were previously masked by broken DAG status logic.
+
+**Hypothesis 1 - Exposed Test Logic Issues**:
+- **Before**: Tests relied only on pipeline status (`SUCCEEDED`) which could be incorrect
+- **After**: DAGs that should fail now properly show `FAILED`, breaking test expectations
+- **Impact**: Tests written assuming broken behavior now fail when DAGs correctly complete
+
+**Hypothesis 2 - Database State Issues**:
+- **Before**: CI database may contain "successful" pipelines with stuck DAGs
+- **After**: Upgrade test queries these legacy pipelines and hangs waiting for DAG completion
+- **Impact**: Historical data inconsistency affects upgrade test logic
+
+**Hypothesis 3 - Infrastructure Timing**:
+- **Unrelated**: API server connectivity, namespace issues, or resource constraints
+- **Coincidental**: Timing issue that happened to appear after DAG fixes were implemented
+
+**Current Status**: 
+- ✅ DAG completion logic working correctly
+- ❌ Upgrade test timing out (may be exposing existing test quality issues)
+- 🔍 **Investigation needed**: Manual testing with cache disabled to determine root cause
+
+**Action Plan**:
+1. **Manual testing**: Deploy with cache disabled and run upgrade test manually for better error visibility
+2. **Root cause analysis**: Determine if timeout is related to DAG fixes or separate infrastructure issue
+3. **Test audit**: If related to DAG fixes, review test expectations and validation logic
+
+**Documentation Note**: This demonstrates that fixing core infrastructure bugs can expose downstream test quality issues that were previously hidden by incorrect behavior.

backend/test/v2/integration/dag_status_conditional_test.go

@@ -53,27 +53,8 @@ type DAGStatusConditionalTestSuite struct {
 
 // createUploadParams creates properly configured upload parameters for CI compatibility
 func (s *DAGStatusConditionalTestSuite) createUploadParams(testName, filePath string) *uploadParams.UploadPipelineParams {
-	uploadParams := uploadParams.NewUploadPipelineParams()
-	
-	// CI FIX: Set required fields that CI environment enforces
-	pipelineName := fmt.Sprintf("%s_test", testName)
-	displayName := fmt.Sprintf("%s Test Pipeline", testName)
-	description := fmt.Sprintf("Test pipeline for %s scenario", testName)
-	
-	// Use resourceNamespace if available (Kubeflow mode), otherwise use kubeflow namespace
-	namespace := s.resourceNamespace
-	if namespace == "" {
-		namespace = "kubeflow"
-	}
-	
-	uploadParams.SetName(&pipelineName)
-	uploadParams.SetDisplayName(&displayName) 
-	uploadParams.SetDescription(&description)
-	if namespace != "" {
-		uploadParams.SetNamespace(&namespace)
-	}
-	
-	return uploadParams
+	// Use standard upload params like other tests in this directory
+	return uploadParams.NewUploadPipelineParams()
 }
 
 func (s *DAGStatusConditionalTestSuite) SetupTest() {

backend/test/v2/integration/dag_status_nested_test.go

@@ -35,27 +35,8 @@ type DAGStatusNestedTestSuite struct {
 
 // createUploadParams creates properly configured upload parameters for CI compatibility
 func (s *DAGStatusNestedTestSuite) createUploadParams(testName, filePath string) *uploadParams.UploadPipelineParams {
-	uploadParams := uploadParams.NewUploadPipelineParams()
-	
-	// CI FIX: Set required fields that CI environment enforces
-	pipelineName := fmt.Sprintf("%s_test", testName)
-	displayName := fmt.Sprintf("%s Test Pipeline", testName)
-	description := fmt.Sprintf("Test pipeline for %s scenario", testName)
-	
-	// Use resourceNamespace if available (Kubeflow mode), otherwise use kubeflow namespace
-	namespace := s.resourceNamespace
-	if namespace == "" {
-		namespace = "kubeflow"
-	}
-	
-	uploadParams.SetName(&pipelineName)
-	uploadParams.SetDisplayName(&displayName) 
-	uploadParams.SetDescription(&description)
-	if namespace != "" {
-		uploadParams.SetNamespace(&namespace)
-	}
-	
-	return uploadParams
+	// Use standard upload params like other tests in this directory
+	return uploadParams.NewUploadPipelineParams()
 }
 
 // Check the namespace have ML pipeline installed and ready

backend/test/v2/integration/dag_status_parallel_for_test.go

@@ -51,27 +51,8 @@ type DAGStatusParallelForTestSuite struct {
 
 // createUploadParams creates properly configured upload parameters for CI compatibility
 func (s *DAGStatusParallelForTestSuite) createUploadParams(testName, filePath string) *uploadParams.UploadPipelineParams {
-	uploadParams := uploadParams.NewUploadPipelineParams()
-	
-	// CI FIX: Set required fields that CI environment enforces
-	pipelineName := fmt.Sprintf("%s_test", testName)
-	displayName := fmt.Sprintf("%s Test Pipeline", testName)
-	description := fmt.Sprintf("Test pipeline for %s scenario", testName)
-	
-	// Use resourceNamespace if available (Kubeflow mode), otherwise use kubeflow namespace
-	namespace := s.resourceNamespace
-	if namespace == "" {
-		namespace = "kubeflow"
-	}
-	
-	uploadParams.SetName(&pipelineName)
-	uploadParams.SetDisplayName(&displayName) 
-	uploadParams.SetDescription(&description)
-	if namespace != "" {
-		uploadParams.SetNamespace(&namespace)
-	}
-	
-	return uploadParams
+	// Use standard upload params like other tests in this directory
+	return uploadParams.NewUploadPipelineParams()
 }
 
 func (s *DAGStatusParallelForTestSuite) SetupTest() {