resolved lint errors

This commit resolves lint errors caused during previous commit.

Author: Surya-7890

internal/contract/version.go

@@ -192,12 +192,8 @@ func GetGKMetadata(ctx context.Context, c client.Reader, gk schema.GroupKind) (*
 // versions. e.g. v2, v1, v1beta2, v1beta1, v1alpha1.
 type kubeAwareAPIVersions []string
 
-// SortFunc uses these constants to determine the order of sorting
 const (
-	// Used to sort in ascending order of occurance
 	ascending = iota
-
-	// Used to sort in descending order of occurance
 	descending
 )
 

internal/controllers/machinedeployment/mdutil/util.go

@@ -42,14 +42,14 @@ import (
 	"sigs.k8s.io/cluster-api/util/conversion"
 )
 
-// Sort functions in this file, use these constants to determine the sorting order
+// Sort functions in this file, use these constants to determine the sorting order.
 const (
-	// Used to sort elements in Ascending order
-	// Also used in cases, where the order is from older to newer occurances
+	// Used to sort elements in Ascending order.
+	// Also used in cases, where the order is from older to newer occurrences.
 	ASCENDING = iota
 
-	// Used to sort elements in Descending order
-	// Also used in cases, where the order is from newer to older occurances
+	// Used to sort elements in Descending order.
+	// Also used in cases, where the order is from newer to older occurrences.
 	DESCENDING
 )
 

util/failuredomains/failure_domains.go

@@ -36,20 +36,20 @@ type failureDomainAggregation struct {
 type failureDomainAggregations []failureDomainAggregation
 
 const (
-	ASCENDING = iota
-	DESCENDING
+	ascending = iota
+	descending
 )
 
 func (f failureDomainAggregations) SortFunc(i, j failureDomainAggregation, order int) int {
 	// If a failure domain has less priority machines then the other, it goes first
 	if i.countPriority < j.countPriority {
-		if order == ASCENDING {
+		if order == ascending {
 			return -1
 		}
 		return 1
 	}
 	if i.countPriority > j.countPriority {
-		if order == ASCENDING {
+		if order == ascending {
 			return 1
 		}
 		return -1
@@ -58,13 +58,13 @@ func (f failureDomainAggregations) SortFunc(i, j failureDomainAggregation, order
 	// If a failure domain has the same number of priority machines then the other,
 	// use the number of overall machines to pick which one goes first.
 	if i.countAll < j.countAll {
-		if order == ASCENDING {
+		if order == ascending {
 			return -1
 		}
 		return 1
 	}
 	if i.countAll > j.countAll {
-		if order == ASCENDING {
+		if order == ascending {
 			return 1
 		}
 		return -1
@@ -73,7 +73,7 @@ func (f failureDomainAggregations) SortFunc(i, j failureDomainAggregation, order
 	// If both failure domain have the same number of priority machines and overall machines, we keep the order
 	// in the list which ensure a certain degree of randomness because the list originates from a map.
 	// This helps to spread machines e.g. when concurrently working on many clusters.
-	if order == ASCENDING {
+	if order == ascending {
 		return 1
 	}
 	return -1
@@ -86,7 +86,7 @@ func PickMost(ctx context.Context, failureDomains []clusterv1.FailureDomain, all
 		return ""
 	}
 	slices.SortFunc(aggregations, func(i, j failureDomainAggregation) int {
-		return aggregations.SortFunc(i, j, DESCENDING)
+		return aggregations.SortFunc(i, j, descending)
 	})
 	if len(aggregations) > 0 && aggregations[0].countPriority > 0 {
 		return aggregations[0].id
@@ -108,7 +108,7 @@ func PickFewest(ctx context.Context, failureDomains []clusterv1.FailureDomain, a
 		return ""
 	}
 	slices.SortFunc(aggregations, func(i, j failureDomainAggregation) int {
-		return aggregations.SortFunc(i, j, ASCENDING)
+		return aggregations.SortFunc(i, j, ascending)
 	})
 	return aggregations[0].id
 }

util/failuredomains/failure_domains_test.go

@@ -871,7 +871,7 @@ func TestFailureDomainAggregationsSort(t *testing.T) {
 	}
 
 	slices.SortFunc(aggregations, func(i, j failureDomainAggregation) int {
-		return aggregations.SortFunc(i, j, ASCENDING)
+		return aggregations.SortFunc(i, j, ascending)
 	})
 
 	// the result should be sorted so the fd with less priority machines are first,