backend: Tests failing

Author: SinghaAnirban005

backend/cmd/headlamp.go

@@ -87,7 +87,6 @@ type HeadlampConfig struct {
 	baseURL                   string
 	oidcScopes                []string
 	proxyURLs                 []string
-	compiledProxyURLs         []glob.Glob
 	cache                     cache.Cache[interface{}]
 	kubeConfigStore           kubeconfig.ContextStore
 	multiplexer               *Multiplexer
@@ -622,7 +621,7 @@ func createExternalProxyHandler(config *HeadlampConfig) http.HandlerFunc {
 			return
 		}
 
-		if !config.isURLAllowed(url.String()) {
+		if !isURLAllowed(config.proxyURLs, url.String()) {
 			logger.Log(logger.LevelError, nil, err, "no allowed proxy url match, request denied")
 			http.Error(w, "no allowed proxy url match, request denied ", http.StatusBadRequest)
 
@@ -642,8 +641,9 @@ func getProxyURL(r *http.Request) string {
 	return proxyURL
 }
 
-func (c *HeadlampConfig) isURLAllowed(targetURL string) bool {
-	for _, g := range c.compiledProxyURLs {
+func isURLAllowed(proxyURLs []string, targetURL string) bool {
+	for _, proxyURL := range proxyURLs {
+		g := glob.MustCompile(proxyURL)
 		if g.Match(targetURL) {
 			return true
 		}
@@ -899,30 +899,6 @@ func buildOIDCRedirectURL(config *HeadlampConfig, cluster, token string) string
 	return redirectURL + fmt.Sprintf("auth?cluster=%s&token=%s", cluster, token)
 }
 
-func (c *HeadlampConfig) compileProxyURLs() error {
-	if len(c.proxyURLs) == 0 {
-		return nil
-	}
-
-	c.compiledProxyURLs = make([]glob.Glob, 0, len(c.proxyURLs))
-	for _, pattern := range c.proxyURLs {
-		pattern = strings.TrimSpace(pattern)
-
-		if pattern == "" {
-			continue
-		}
-
-		g, err := glob.Compile(pattern)
-		if err != nil {
-			return fmt.Errorf("invalid proxy URL pattern %q: %w", pattern, err)
-		}
-
-		c.compiledProxyURLs = append(c.compiledProxyURLs, g)
-	}
-
-	return nil
-}
-
 func parseClusterAndToken(r *http.Request) (string, string) {
 	cluster := ""
 	re := regexp.MustCompile(`^/clusters/([^/]+)/.*`)

backend/cmd/server.go

@@ -44,7 +44,7 @@ func main() {
 	kubeConfigStore := kubeconfig.NewContextStore()
 	multiplexer := NewMultiplexer(kubeConfigStore)
 
-	serverConfig := &HeadlampConfig{
+	StartHeadlampServer(&HeadlampConfig{
 		useInCluster:              conf.InCluster,
 		kubeConfigPath:            conf.KubeConfigPath,
 		skippedKubeContexts:       conf.SkippedKubeContexts,
@@ -80,14 +80,7 @@ func main() {
 			StdoutTraceEnabled: conf.StdoutTraceEnabled,
 			SamplingRate:       conf.SamplingRate,
 		},
-	}
-
-	if err := serverConfig.compileProxyURLs(); err != nil {
-		logger.Log(logger.LevelError, nil, err, "Failed to compile proxy URL patterns")
-		os.Exit(1)
-	}
-
-	StartHeadlampServer(serverConfig)
+	})
 }
 
 func runListPlugins() {