Skip to content

Commit cfd09a8

Browse files
authored
Merge pull request #800 from laravel/laravel8
[6.x] Support Laravel 8
2 parents db10ac7 + d94fad8 commit cfd09a8

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.github/workflows/tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ jobs:
1414
fail-fast: true
1515
matrix:
1616
php: [7.2, 7.3, 7.4]
17-
laravel: [^6.0, ^7.0]
17+
laravel: [^6.0, ^7.0, ^8.0]
1818
phpunit: [^7.5, ^8.0, ^9.0]
1919
exclude:
2020
- php: 7.2
2121
phpunit: ^9.0
22+
- php: 7.2
23+
laravel: ^8.0
2224

2325
name: P${{ matrix.php }} - L${{ matrix.laravel }} - U${{ matrix.phpunit }}
2426

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
"ext-zip": "*",
1616
"php-webdriver/webdriver": "^1.8.1",
1717
"nesbot/carbon": "^2.0",
18-
"illuminate/console": "^6.0|^7.0",
19-
"illuminate/support": "^6.0|^7.0",
18+
"illuminate/console": "^6.0|^7.0|^8.0",
19+
"illuminate/support": "^6.0|^7.0|^8.0",
2020
"symfony/console": "^4.3|^5.0",
2121
"symfony/finder": "^4.3|^5.0",
2222
"symfony/process": "^4.3|^5.0",

tests/ComponentTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ public function test_resolver_prefix()
3535
$driver = m::mock(stdClass::class);
3636
$browser = new Browser($driver);
3737

38-
$browser->within($component = new TestComponent, function ($browser) use ($component) {
38+
$browser->within($component = new TestComponent, function ($browser) {
3939
$this->assertEquals('body #component-root', $browser->resolver->prefix);
4040

41-
$browser->within($nested = new TestNestedComponent, function ($browser) use ($nested) {
41+
$browser->within($nested = new TestNestedComponent, function ($browser) {
4242
$this->assertEquals('body #component-root #nested-root', $browser->resolver->prefix);
4343

4444
$browser->with('prefix', function ($browser) {
@@ -75,7 +75,7 @@ public function test_component_elements()
7575
'@overridden-alias' => '#not-overridden',
7676
], $browser->resolver->elements);
7777

78-
$browser->within($nested = new TestNestedComponent, function ($browser) use ($nested) {
78+
$browser->within($nested = new TestNestedComponent, function ($browser) {
7979
$this->assertEquals([
8080
'@nested-alias' => '#nested-alias',
8181
'@overridden-alias' => '#overridden',

0 commit comments

Comments
 (0)