Skip to content

Commit 0a83a35

Browse files
committed
Recognize, but do not process, issuevmc CAA tags
1 parent 3dc9886 commit 0a83a35

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

va/caa.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,12 @@ func filterCAA(rrs []*dns.CAA) ([]*dns.CAA, []*dns.CAA, bool) {
208208
// of course we do not do any further processing, as we do not issue
209209
// S/MIME certificates.
210210
continue
211+
case "issuevmc":
212+
// We support the issuevmc property tag insofar as we recognize it and
213+
// therefore do not bail out if someone has a critical issuevmc tag. But
214+
// of course we do not do any further processing, as we do not issue
215+
// VMC certificates.
216+
continue
211217
default:
212218
// The critical flag is the bit with significance 128. However, many CAA
213219
// record users have misinterpreted the RFC and concluded that the bit

va/caa_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,6 +1163,7 @@ func TestFilterCAA(t *testing.T) {
11631163
{Tag: "issuewild", Value: "b"},
11641164
{Tag: "iodef", Value: "c"},
11651165
{Tag: "issuemail", Value: "c"},
1166+
{Tag: "issuevmc", Value: "c"},
11661167
},
11671168
expectedIssueVals: []string{"a"},
11681169
expectedWildVals: []string{"b"},
@@ -1174,6 +1175,7 @@ func TestFilterCAA(t *testing.T) {
11741175
{Tag: "issuewild", Value: "b", Flag: 128},
11751176
{Tag: "iodef", Value: "c", Flag: 128},
11761177
{Tag: "issuemail", Value: "c", Flag: 128},
1178+
{Tag: "issuevmc", Value: "c", Flag: 128},
11771179
},
11781180
expectedIssueVals: []string{"a"},
11791181
expectedWildVals: []string{"b"},

0 commit comments

Comments
 (0)