-
-
Notifications
You must be signed in to change notification settings - Fork 631
Update certificate-transparency-go to get static/tiled log support #8150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I was kinda surprised by some of the new dependencies. Some So prometheus is responsible for our new dependencies on zstd and goautoneg. I'd like to dig into that repository's history and see why, and if there is an alternative. Similarly, it's a little surprising to me that certificate-transparency-go requires k8s.io/klog, and I'd love to see if that dependency can be excised. Still I don't think those need to block this PR. |
|
Yeesh, I read the diff wrong for a few of these:
This dependency is removed, yay!
We've had this dependency for a while and it's just being modified. |
This package was originally inlined into the prometheus/common repo, and was changed to depend on an identical, but external, package in prometheus/common#625. It's an HTTP Content-Type negotiation library. It's used in prometheus/common/expfmt as part of a Negotiate function that takes an HTTP header: https://github.com/prometheus/common/blob/8de85c23e0a24867586e51006eb260b57a10cc78/expfmt/encode.go#L60-L68 That Negotiate function isn't called from prometheus/client_golang, but a separate MetricFamilyToText is called: https://github.com/prometheus/client_golang/blob/96a5ad6ef56e0d41d3bf06ba0478b34a0c718a92/prometheus/registry.go#L605-L606 So, it's a dependency that's not strictly needed, but a PR to separate out its use in the prometheus packages would probably be too invasive. |
#8150 updated our runtime protobuf dependency from v1.34.1 to v1.36.5. This change does the same for our build-time dependency, to keep them in sync.
Update github.com/google/certificate-transparency-go from v1.1.6 to v1.3.1. This updates the loglist file schema to recognize logs which are tagged as being tiled logs / implementing the static CT API.
Transitively update:
Remove one indirect dependency:
Add two new indirect dependencies:
Also fix two unit tests which need minor modifications to work with updated type signatures and behavior.
Part of #7872