multi: prepare for new non-constant string rule

In preparation for the next commit which bumps golang to a newer
version, we want to make some code changes that would otherwise render
some log-related calls problematic. With go1.24 a new govet rule was
added that disallows non-constant strings (i.e including a tag like
"%s") in calls to printf. See more in the [related
issue](golang/go#60529).

Author: GeorgeTsagk

itest/network_harness.go

@@ -270,12 +270,10 @@ out:
 
 	n.EnsureConnected(t, n.Alice, n.Bob)
 
-	logLine := fmt.Sprintf(
-		"STARTING ============ %v ============\n", testCase,
-	)
+	logLine := "STARTING ============ %v ============\n"
 
-	n.Alice.AddToLog(logLine)
-	n.Bob.AddToLog(logLine)
+	n.Alice.AddToLog(logLine, testCase)
+	n.Bob.AddToLog(logLine, testCase)
 
 	return nil
 }

rpc_proxy.go

@@ -364,7 +364,7 @@ func (p *rpcProxy) makeDirector(allowLitRPC bool) func(ctx context.Context,
 		// gRPC server.
 		handled, conn, err := p.subServerMgr.GetRemoteConn(requestURI)
 		if err != nil {
-			return outCtx, nil, status.Errorf(
+			return outCtx, nil, status.Error(
 				codes.Unavailable, err.Error(),
 			)
 		}

rpcmiddleware/proto.go

@@ -54,7 +54,7 @@ func RPCErr(req *lnrpc.RPCMiddlewareRequest,
 	err error) (*lnrpc.RPCMiddlewareResponse, error) {
 
 	if err != nil {
-		return RPCErrString(req, err.Error())
+		return RPCErrString(req, err.Error(), nil)
 	}
 
 	return RPCOk(req)

status/manager.go

@@ -258,24 +258,34 @@ func (s *Manager) SetStopped(name string) {
 //
 // NOTE: This will silently fail if the referenced sub-server has not yet been
 // registered.
-func (s *Manager) SetErrored(name string, errStr string,
-	params ...interface{}) {
-
+func (s *Manager) SetErrored(name string, errStr string) {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
-	err := fmt.Sprintf(errStr, params...)
-
-	log.Debugf("Setting the %s sub-server as errored: %s", name, err)
+	log.Debugf("Setting the %s sub-server as errored: %s", name, errStr)
 
 	ss, ok := s.subServers[name]
 	if !ok {
 		return
 	}
 
-	log.Errorf("could not start the %s sub-server: %s", name, err)
+	log.Errorf("could not start the %s sub-server: %s", name, errStr)
 
 	ss.running = false
-	ss.err = err
+	ss.err = errStr
 	ss.customStatus = ""
 }
+
+// SetErroredf can be used to set the status of a sub-server as not Running and
+// also set an error message for the sub-server. This function can also accept
+// non-constant strings which may contain extra arguments.
+//
+// NOTE: This will silently fail if the referenced sub-server has not yet been
+// registered.
+func (s *Manager) SetErroredf(name string, errStr string,
+	params ...interface{}) {
+
+	errStr = fmt.Sprintf(errStr, params...)
+
+	s.SetErrored(name, errStr)
+}

terminal.go

@@ -402,7 +402,7 @@ func (g *LightningTerminal) Run(ctx context.Context) error {
 	// could not start or LND could not start or be connected to.
 	startErr := g.start(ctx)
 	if startErr != nil {
-		g.statusMgr.SetErrored(
+		g.statusMgr.SetErroredf(
 			subservers.LIT, "could not start Lit: %v", startErr,
 		)
 	}
@@ -431,10 +431,7 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 	var err error
 
 	accountServiceErrCallback := func(err error) {
-		g.statusMgr.SetErrored(
-			subservers.ACCOUNTS,
-			err.Error(),
-		)
+		g.statusMgr.SetErrored(subservers.ACCOUNTS, err.Error())
 
 		log.Errorf("Error thrown in the accounts service, keeping "+
 			"litd running: %v", err,
@@ -610,7 +607,7 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 	// Connect to LND.
 	g.lndConn, err = connectLND(g.cfg, bufRpcListener)
 	if err != nil {
-		g.statusMgr.SetErrored(
+		g.statusMgr.SetErroredf(
 			subservers.LND, "could not connect to LND: %v", err,
 		)
 
@@ -723,7 +720,7 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 	// servers, as the setup will be fast.
 	err = g.setupBasicLNDClient(ctx, lndQuit)
 	if err != nil {
-		g.statusMgr.SetErrored(
+		g.statusMgr.SetErroredf(
 			subservers.LND,
 			"could not to set up a basic LND client: %v", err,
 		)
@@ -756,7 +753,7 @@ func (g *LightningTerminal) start(ctx context.Context) error {
 	// needed for LiT to be fully started.
 	err = g.setupFullLNDClient(ctx, lndQuit)
 	if err != nil {
-		g.statusMgr.SetErrored(
+		g.statusMgr.SetErroredf(
 			subservers.LND,
 			"could not to set up a full LND client: %v", err,
 		)
@@ -880,7 +877,7 @@ func (g *LightningTerminal) setupBasicLNDClient(ctx context.Context,
 			break
 		}
 
-		g.statusMgr.SetErrored(
+		g.statusMgr.SetErroredf(
 			subservers.LIT,
 			"Error when setting up basic LND Client: %v", err,
 		)
@@ -962,7 +959,7 @@ func (g *LightningTerminal) setupFullLNDClient(ctx context.Context,
 			break
 		}
 
-		g.statusMgr.SetErrored(
+		g.statusMgr.SetErroredf(
 			subservers.LIT,
 			"Error when creating LND Services client: %v",
 			err,