Skip to content

Commit 1be5fac

Browse files
author
Hyunsik Kang
authored
Merge pull request #42 from cj848/feature/improve-test
Abstract Test Classes does not directly access EntityManager methods
2 parents 1539e78 + ece0ccb commit 1be5fac

File tree

38 files changed

+89
-273
lines changed

38 files changed

+89
-273
lines changed
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.criteriaquery
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.criteriaquery.AbstractCriteriaDeleteIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
class EclipselinkCriteriaDeleteIntegrationTest : AbstractCriteriaDeleteIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
class EclipselinkCriteriaDeleteIntegrationTest : AbstractCriteriaDeleteIntegrationTest()
Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.expression
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.expression.AbstractCriteriaQueryDslExpressionIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslExpressionIntegrationTest : AbstractCriteriaQueryDslExpressionIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslExpressionIntegrationTest :
6+
AbstractCriteriaQueryDslExpressionIntegrationTest()
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.from
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.from.AbstractCriteriaQueryDslFromIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslFromIntegrationTest : AbstractCriteriaQueryDslFromIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslFromIntegrationTest : AbstractCriteriaQueryDslFromIntegrationTest()
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.groupby
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.groupby.AbstractCriteriaQueryDslGroupByIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslGroupByIntegrationTest : AbstractCriteriaQueryDslGroupByIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslGroupByIntegrationTest : AbstractCriteriaQueryDslGroupByIntegrationTest()
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.having
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.having.AbstractCriteriaQueryDslHavingIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslHavingIntegrationTest : AbstractCriteriaQueryDslHavingIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslHavingIntegrationTest : AbstractCriteriaQueryDslHavingIntegrationTest()

eclipselink/src/test/kotlin/com/linecorp/kotlinjdsl/eclipselink/integration/querydsl/hint/EclipselinkCriteriaQueryDslHintIntegrationTest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,12 @@ import com.linecorp.kotlinjdsl.querydsl.expression.col
55
import com.linecorp.kotlinjdsl.querydsl.expression.min
66
import com.linecorp.kotlinjdsl.test.entity.order.Order
77
import com.linecorp.kotlinjdsl.test.integration.AbstractCriteriaQueryDslIntegrationTest
8-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
98
import org.eclipse.persistence.config.PessimisticLock
109
import org.eclipse.persistence.config.QueryHints
1110
import org.junit.jupiter.api.BeforeEach
1211
import org.junit.jupiter.api.Test
13-
import org.junit.jupiter.api.extension.ExtendWith
14-
import javax.persistence.EntityManager
1512

16-
@ExtendWith(EntityManagerExtension::class)
1713
internal class EclipselinkCriteriaQueryDslHintIntegrationTest : AbstractCriteriaQueryDslIntegrationTest() {
18-
override lateinit var entityManager: EntityManager
1914

2015
private val order1 = order { purchaserId = 1000 }
2116
private val order2 = order { purchaserId = 1000 }
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.limit
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.limit.AbstractCriteriaQueryDslLimitIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslLimitIntegrationTest : AbstractCriteriaQueryDslLimitIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslLimitIntegrationTest : AbstractCriteriaQueryDslLimitIntegrationTest()
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.orderby
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.orderby.AbstractCriteriaQueryDslOrderByIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslOrderByIntegrationTest : AbstractCriteriaQueryDslOrderByIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslOrderByIntegrationTest : AbstractCriteriaQueryDslOrderByIntegrationTest()
Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.predicate
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.predicate.AbstractCriteriaQueryDslPredicateIntegrationTest
5-
import org.junit.jupiter.api.extension.ExtendWith
6-
import javax.persistence.EntityManager
74

8-
@ExtendWith(EntityManagerExtension::class)
9-
internal class EclipselinkCriteriaQueryDslPredicateIntegrationTest : AbstractCriteriaQueryDslPredicateIntegrationTest() {
10-
override lateinit var entityManager: EntityManager
11-
}
5+
internal class EclipselinkCriteriaQueryDslPredicateIntegrationTest : AbstractCriteriaQueryDslPredicateIntegrationTest()

eclipselink/src/test/kotlin/com/linecorp/kotlinjdsl/eclipselink/integration/querydsl/select/EclipselinkCriteriaQueryDslSelectIntegrationTest.kt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
package com.linecorp.kotlinjdsl.eclipselink.integration.querydsl.select
22

3-
import com.linecorp.kotlinjdsl.test.integration.EntityManagerExtension
43
import com.linecorp.kotlinjdsl.test.integration.querydsl.select.AbstractCriteriaQueryDslSelectIntegrationTest
54
import org.eclipse.persistence.internal.jpa.querydef.SelectionImpl
65
import org.eclipse.persistence.internal.jpa.querydef.SubQueryImpl
76
import org.junit.jupiter.api.Test
8-
import org.junit.jupiter.api.extension.ExtendWith
9-
import javax.persistence.EntityManager
107

11-
@ExtendWith(EntityManagerExtension::class)
128
class EclipselinkCriteriaQueryDslSelectIntegrationTest : AbstractCriteriaQueryDslSelectIntegrationTest() {
13-
override lateinit var entityManager: EntityManager
149

1510
/**
1611
* https://wiki.eclipse.org/EclipseLink/UserGuide/JPA/Basic_JPA_Development/Querying/JPQL#Sub-selects_in_FROM_clause

0 commit comments

Comments
 (0)