feat: ignore URL params on matching

Author: tenorok

src/utils/array.js

@@ -8,7 +8,6 @@ import {
     getResponseHeaderMap,
     defaultResponseHeaders,
 } from './headers';
-import { arrayEquals } from './array';
 import { getNormalizedUrl } from './url';
 
 let global =
@@ -34,9 +33,9 @@ export class Faker {
 
     getRequests = () => Object.values(this.requestMap);
 
-    getKey = (url = '', searchParamKeys = [], method = 'GET') =>
+    getKey = (url = '', method = 'GET') =>
         url && method
-            ? [url, ...searchParamKeys, method.toLowerCase()].join('_')
+            ? [url, method.toLowerCase()].join('_')
             : '';
 
     makeInitialRequestMap = (requests) => {
@@ -51,12 +50,9 @@ export class Faker {
     };
 
     add = (request) => {
-        const { path, searchParamKeys } = getNormalizedUrl(request.url);
-        const key = this.getKey(path, searchParamKeys, request.method);
+        const key = this.getKey(request.url, request.method);
         this.requestMap[key] = {
             ...request,
-            path,
-            searchParamKeys,
             method: request.method || 'GET',
             status: request.status || 200,
             delay: request.delay || 0,
@@ -66,8 +62,7 @@ export class Faker {
 
     update = (item, fieldKey, value) => {
         const { url, method } = item;
-        const { path, searchParamKeys } = getNormalizedUrl(url);
-        const itemKey = this.getKey(path, searchParamKeys, method);
+        const itemKey = this.getKey(url, method);
 
         if (
             // eslint-disable-next-line no-prototype-builtins
@@ -80,17 +75,17 @@ export class Faker {
     };
 
     matchMock = (url, method = 'GET') => {
-        const { path, searchParamKeys } = getNormalizedUrl(url);
+        const { fullUrl } = getNormalizedUrl(url);
 
         for (let key in this.requestMap) {
             const { url: requestUrl, method: requestMethod } =
                 this.requestMap[key];
-            const { path: requestPath, searchParamKeys: requestSearchKeys } =
+            const { fullUrlEscaped } =
                 getNormalizedUrl(requestUrl);
+
             if (
-                match(requestPath)(path) &&
+                match(fullUrlEscaped)(fullUrl) &&
                 method == requestMethod &&
-                arrayEquals(searchParamKeys, requestSearchKeys) &&
                 !this.requestMap[key].skip
             ) {
                 return this.requestMap[key];

src/utils/faker.js

@@ -8,14 +8,10 @@ describe('Faker', () => {
             const actual = faker.getKey('', [], '');
             expect(actual).toEqual('');
         });
-        it('should return a string binding url and method with underscore if searchParamKeys is empty', () => {
-            const actual = faker.getKey('google.com', [], 'GET');
+        it('should return a string binding url and method with underscore', () => {
+            const actual = faker.getKey('google.com', 'GET');
             expect(actual).toEqual('google.com_get');
         });
-        it('should return a string binding url, search params keys, and method with underscore', () => {
-            const actual = faker.getKey('google.com', ['all', 'only'], 'GET');
-            expect(actual).toEqual('google.com_all_only_get');
-        });
     });
     describe('makeInitialRequestMap', () => {
         const faker = new Faker();
@@ -69,6 +65,13 @@ describe('Faker', () => {
                 response: {},
                 delay: 0,
             },
+            {
+                url: 'http://request.com?a=1&b=2',
+                method: 'GET',
+                status: 200,
+                response: {},
+                delay: 0,
+            },
         ];
         faker.makeInitialRequestMap(requests);
 
@@ -88,6 +91,12 @@ describe('Faker', () => {
             expect(actual.method).toEqual(requests[2].method);
             expect(actual.skip).toEqual(false);
         });
+        it('should return request if url matches with the query parameters', () => {
+            const actual = faker.matchMock('http://request.com?a=1&b=2', 'GET');
+            expect(actual.url).toEqual(requests[3].url);
+            expect(actual.method).toEqual(requests[3].method);
+            expect(actual.skip).toEqual(false);
+        });
     });
 
     describe('restore', () => {

src/utils/faker.test.js

@@ -14,8 +14,13 @@ export const getNormalizedUrl = (rawUrl = '') => {
             searchParamKeys.push(key);
         }
     }
+
+    const searchEscaped = url.search ? '\\' + url.search : '';
+
     return {
         path: url.host + url.pathname,
         searchParamKeys,
+        fullUrl: url.host + url.pathname + url.search,
+        fullUrlEscaped: url.host + url.pathname + searchEscaped,
     };
 };