Skip to content

Commit 239128e

Browse files
Merge pull request #79 from linked-planet/dev
Dev
2 parents 50aae7b + 1b48184 commit 239128e

File tree

12 files changed

+1022
-620
lines changed

12 files changed

+1022
-620
lines changed

library/src/components/Flag.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,7 @@ export function Flag({
221221
data-testid={testId}
222222
>
223223
{icon && (
224-
<div>
225-
<p className="flex items-center justify-center">{icon}</p>
226-
</div>
224+
<div className="flex items-start justify-center">{icon}</div>
227225
)}
228226
<div>
229227
<div className="mb-2 font-bold">{title}</div>

library/src/components/form/DynamicForm.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
} from "react-hook-form"
1111
import { twMerge } from "tailwind-merge"
1212
import { Button, ButtonGroup } from "../Button"
13+
import {useEffect} from "react";
1314

1415
export interface FormProps<T extends FieldValues> {
1516
control: Control<T>
@@ -73,6 +74,10 @@ export function DynamicForm<T extends FieldValues>({
7374
defaultValues: obj,
7475
})
7576

77+
useEffect(() => {
78+
reset(obj)
79+
}, [obj, reset])
80+
7681
const onReset = (e: React.FormEvent) => {
7782
e.preventDefault()
7883
reset()

library/src/components/inputs/Select.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ function SelectInForm<
700700
let valueUsed = value
701701

702702
// controlled
703-
if (value) {
703+
if (value !== undefined) {
704704
if (!isMulti && isOptionType(value) && value.value !== field.value) {
705705
field.onChange(value.value)
706706
}
@@ -723,7 +723,7 @@ function SelectInForm<
723723
//
724724

725725
// uncontrolled
726-
if (!value) {
726+
if (value === undefined) {
727727
if (!isMulti && options) {
728728
for (const opt of options) {
729729
if (isOptionType(opt) && opt.value === field.value) {
@@ -739,9 +739,9 @@ function SelectInForm<
739739
}
740740
}
741741
}
742-
/*if (!valueUsed) {
743-
valueUsed = field.value
744-
}*/
742+
if (field.value === null) {
743+
valueUsed = null
744+
}
745745
} else if (isMulti && options) {
746746
const multiValueUsed = []
747747
if (field.value) {

library/src/layouting/AppLayout.tsx

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ export function initTopNavigationHeight() {
2929
}
3030
const topNavHeight = topNav[0].clientHeight
3131
if (topNavHeight) {
32+
console.info("UIKitTs - Top navigation height set to:", topNavHeight)
3233
document.documentElement.style.setProperty(
3334
topNavigationHeightVar,
3435
`${topNavHeight}px`,
@@ -40,6 +41,7 @@ export function initTopNavigationHeight() {
4041
const header = headers.item(i)
4142
if (header?.getAttribute("role") === "banner") {
4243
const bannerHeight = header.clientHeight || 0
44+
console.info("UIKitTs - Banner height set to:", bannerHeight)
4345
document.documentElement.style.setProperty(
4446
bannerHeightVar,
4547
`${bannerHeight}px`,
@@ -54,7 +56,7 @@ export function initTopNavigationHeight() {
5456

5557
if (!uikts_layouting_heightCB) {
5658
window.addEventListener("resize", initTopNavigationHeight)
57-
console.info("Added resize event listener for App layouting")
59+
console.info("UIKitTs - Added resize event listener for App layouting")
5860
uikts_layouting_heightCB = true
5961
}
6062
}
@@ -68,11 +70,13 @@ function Container({
6870
className,
6971
style,
7072
testId,
73+
useBanner = false,
7174
}: {
7275
children: React.ReactNode
7376
className?: string
7477
style?: React.CSSProperties
7578
testId?: string
79+
useBanner?: boolean
7680
}) {
7781
return (
7882
<div
@@ -83,15 +87,24 @@ function Container({
8387
data-layout-container="true"
8488
data-testid={testId}
8589
style={{
86-
gridTemplateAreas: `
90+
gridTemplateAreas: useBanner
91+
? `
8792
"left-panel banner right-panel"
8893
"left-panel top-navigation right-panel"
8994
"left-panel content right-panel"
95+
`
96+
: `
97+
"left-panel top-navigation right-panel"
98+
"left-panel content right-panel"
9099
`,
91100
gridTemplateColumns: `var(${leftPanelWidthVar}, 0px) minmax(0, 1fr) var(${rightPanelWidthVar}, 0px)`,
92-
gridTemplateRows: `var(${topNavigationHeightVar}, min-content) 1fr`,
101+
gridTemplateRows: useBanner
102+
? `var(${bannerHeightVar}, 0) var(${topNavigationHeightVar}, min-content) 1fr`
103+
: `var(${topNavigationHeightVar}, min-content) 1fr`,
93104
outline: "none",
94-
height: `calc(100dvh - var(${bannerHeightVar}, 0px))`,
105+
height: useBanner
106+
? "100dvh"
107+
: `calc(100dvh - var(${bannerHeightVar}, 0px))`,
95108
...style,
96109
}}
97110
>

0 commit comments

Comments
 (0)