Skip to content

Commit 138fe46

Browse files
author
Andrew Choi
authored
Metrics Export Service Config and Properties to include Commit-latency-service -> commit-offset-latency-ms-avg (#227)
Append: "kmf.services:type=commit-latency-service,name=:commit-offset-latency-ms-avg", "kmf.services:type=commit-latency-service,name=:commit-offset-latency-ms-max", "kmf.services:type=commit-latency-service,name=:commit-offset-latency-ms-99th", "kmf.services:type=commit-latency-service,name=:commit-offset-latency-ms-999th", "kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-9999th" --> for consumer offset commit latency metrics. Remove: "kmf.services:type=commit-availability-service,name=:commit-latency-avg", "kmf.services:type=commit-availability-service,name=:commit-availability-avg", --> commit-latency-avg" and commit-availability-avg are outdated names which is renamed to commit-offset-latency-ms-avg. Signed-off-by: Andrew Choi <[email protected]>
1 parent 14aa285 commit 138fe46

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

config/kafka-monitor.properties

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@
8181
"kmf.services:type=produce-service,name=*:produce-availability-avg",
8282
"kmf.services:type=consume-service,name=*:consume-availability-avg",
8383
"kmf.services:type=commit-availability-service,name=*:offsets-committed-avg",
84-
"kmf.services:type=commit-availability-service,name=*:commit-latency-avg",
85-
"kmf.services:type=commit-availability-service,name=*:commit-availability-avg",
8684
"kmf.services:type=commit-availability-service,name=*:failed-commit-offsets-avg",
8785
"kmf.services:type=produce-service,name=*:records-produced-total",
8886
"kmf.services:type=consume-service,name=*:records-consumed-total",
@@ -94,6 +92,11 @@
9492
"kmf.services:type=produce-service,name=*:produce-error-rate",
9593
"kmf.services:type=consume-service,name=*:consume-error-rate",
9694
"kmf.services:type=commit-availability-service,name=*:offsets-committed-total",
95+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-avg",
96+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-max",
97+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-99th",
98+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-999th",
99+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-9999th",
97100
"kmf.services:type=commit-availability-service,name=*:failed-commit-offsets-total"
98101
]
99102
}

src/main/java/com/linkedin/kmf/apps/SingleClusterMonitor.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,11 @@ public static void main(String[] args) throws Exception {
336336
"kmf.services:type=commit-availability-service,name=*:offsets-committed-avg",
337337
"kmf.services:type=commit-availability-service,name=*:failed-commit-offsets-total",
338338
"kmf.services:type=commit-availability-service,name=*:failed-commit-offsets-avg",
339-
"kmf.services:type=commit-availability-service,name=*:commit-latency-avg"
339+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-avg",
340+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-max",
341+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-99th",
342+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-999th",
343+
"kmf.services:type=commit-latency-service,name=*:commit-offset-latency-ms-9999th"
340344
);
341345
props.put(DefaultMetricsReporterServiceConfig.REPORT_METRICS_CONFIG, metrics);
342346

0 commit comments

Comments
 (0)