Skip to content

Commit f681dc4

Browse files
author
Andrew Choi
authored
change LOG level to debug for commit offsets already in progress (#241)
Offset commit already in progress is not a critical error that should kill the process. Some commit tasks (Futures threads) take longer to complete and due to the nature of async commits, some commits take longer. Thus, changing level of Logging to debug is sufficient here. Signed-off-by: Andrew Choi [email protected]
1 parent b418342 commit f681dc4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/com/linkedin/kmf/services/CommitLatencyMetrics.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void recordCommitStart() throws Exception {
6868
_inProgressCommit = true;
6969
} else {
7070
// inProgressCommit is already set to TRUE;
71-
throw new Exception("Offset commit is already in progress.");
71+
LOG.debug("Offset commit is already in progress.");
7272
}
7373
}
7474

@@ -83,7 +83,7 @@ public void recordCommitComplete() {
8383
_inProgressCommit = false;
8484
} else {
8585
// inProgressCommit is already set to FALSE;
86-
LOG.error("Offset commit is not in progress. CommitLatencyMetrics shouldn't completing a record commit here.");
86+
LOG.debug("Offset commit is not in progress. CommitLatencyMetrics shouldn't completing a record commit here.");
8787
}
8888
}
8989

0 commit comments

Comments
 (0)