You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
repro:
git fetch origin #make sure we are on master
git checkout origin/master
git reset --hard
git checkout -b t480_t480s_merged_upstream #make changes in branch
git fetch https://review.coreboot.org/coreboot refs/changes/74/83274/42 && git format-patch -1 --stdout FETCH_HEAD > patches/coreboot-24.12/0003-mb-lenovo-Add-ThinkPad-T480-and-ThinkPad-T480s.patch #replace patch from upstream download section of https://review.coreboot.org/c/coreboot/+/83274
echo "bogus" |sudo tee build/x86/coreboot-24.12/.canary > /dev/null #overwrite cloned git canary with bad commit revision so repo is synced and patched clean
./docker_repro.sh make BOARD=EOL_t480-maximized #Build to see it fail with now unneeded patch
rm patches/coreboot-24.12/0004-do-not-break-building-other-thinkpads-with-the-hacks.patch #remove now uneeded hack on previous WiP coreboot patches for t480/t480s
echo "bogus" |sudo tee build/x86/coreboot-24.12/.canary > /dev/null #overwrite cloned git canary with bad commit revision so repo is synced and patched clean
./docker_repro.sh make BOARD=EOL_t480-maximized #builds successfully with newly merged https://review.coreboot.org/c/coreboot/+/83274
Signed-off-by: Thierry Laurion <[email protected]>
0 commit comments