refactor: remove obsolete SMB service tests

1. Removed redundant test cases for smbd auto start since functionality
is now handled differently
2. Eliminated tests for obsolete service management methods
(startService, enableServiceAsync)
3. Simplified service checking logic tests to use enableServiceNow
directly
4. Cleaned up test cases that were testing implementation details rather
than behavior
5. Removed EnableSmbServices tests as this functionality has been
deprecated
6. Various whitespace and formatting fixes in test files

The changes reflect architectural improvements where:
1. Service management has been consolidated into simpler, more reliable
methods
2. Obsolete D-Bus interactions have been removed
3. Implementation details were over-tested compared to behavior
4. The codebase has moved away from direct SMB service manipulation

refactor: 移除过时的SMB服务测试

1. 移除了smbd自动启动的冗余测试用例，该功能现在以不同方式处理
2. 删除了过时服务管理方法(startService, enableServiceAsync)的测试
3. 简化了服务检查逻辑测试，直接使用enableServiceNow方法
4. 清理了测试实现细节而非行为的测试用例
5. 移除了EnableSmbServices测试，该功能已被弃用
6. 测试文件中各种空格和格式修正

这些变更反映了架构改进：
1. 服务管理已整合为更简单可靠的方法
2. 过时的D-Bus交互已被移除
3. 之前过度测试了实现细节而非行为
4. 代码库已转向不再直接操作SMB服务

Author: Johnson-zs

autotests/plugins/dfmplugin-dirshare/test_usersharehelper.cpp

@@ -339,8 +339,6 @@ TEST_F(UT_UserShareHelper, SetSmbdAutoStart)
     DeclareDBusCallFunc_Custom(const QString &);
     auto call = static_cast<Call>(&QDBusAbstractInterface::call);
     stub.set_lamda(call, [] { __DBG_STUB_INVOKE__ return QDBusMessage(); });
-    EXPECT_NO_FATAL_FAILURE(UserShareHelperInstance->setSmbdAutoStart());
-    EXPECT_FALSE(UserShareHelperInstance->setSmbdAutoStart());
 }
 
 TEST_F(UT_UserShareHelper, IsValidShare)

autotests/plugins/dfmplugin-smbbrowser/test_smbbrowserutils.cpp

@@ -94,10 +94,6 @@ TEST_F(UT_SmbBrowserUtils, IsServiceRuninig)
 
 TEST_F(UT_SmbBrowserUtils, StartService)
 {
-    EXPECT_FALSE(smb_browser_utils::startService(""));
-    EXPECT_FALSE(smb_browser_utils::startService("hello"));
-    EXPECT_FALSE(smb_browser_utils::startService("xxx..."));
-
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
     //    stub.set_lamda(&QDBusAbstractInterface::asyncCall, [] { __DBG_STUB_INVOKE__ return QDBusPendingCall::fromError(QDBusError()); });
     typedef QDBusPendingCall (QDBusAbstractInterface::*AsyncCall)(const QString &method,
@@ -116,28 +112,6 @@ TEST_F(UT_SmbBrowserUtils, StartService)
 
     stub.set_lamda(&QDBusPendingCall::waitForFinished, [] { __DBG_STUB_INVOKE__ });
     stub.set_lamda(&QDBusPendingCall::isValid, [] { __DBG_STUB_INVOKE__ return true; });
-    EXPECT_TRUE(smb_browser_utils::startService("smb"));
-    EXPECT_TRUE(smb_browser_utils::startService("nmb"));
-    EXPECT_FALSE(smb_browser_utils::startService("nmbd"));
-}
-
-TEST_F(UT_SmbBrowserUtils, EnableServiceAsync)
-{
-#if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
-    typedef QDBusPendingCall (QDBusAbstractInterface::*AsyncCall)(const QString &method,
-                                                                  const QVariant &arg1,
-                                                                  const QVariant &arg2,
-                                                                  const QVariant &arg3,
-                                                                  const QVariant &arg4,
-                                                                  const QVariant &arg5,
-                                                                  const QVariant &arg6,
-                                                                  const QVariant &arg7,
-                                                                  const QVariant &arg8);
-    stub.set_lamda(static_cast<AsyncCall>(&QDBusAbstractInterface::asyncCall), []() { __DBG_STUB_INVOKE__ return QDBusPendingCall::fromError(QDBusError()); });
-#else
-    stub.set_lamda(&QDBusAbstractInterface::doAsyncCall, [] { __DBG_STUB_INVOKE__ return QDBusPendingCall::fromError(QDBusError()); });
-#endif
-    EXPECT_NO_FATAL_FAILURE(smb_browser_utils::enableServiceAsync());
 }
 
 TEST_F(UT_SmbBrowserUtils, CheckAndEnableService)
@@ -147,12 +121,9 @@ TEST_F(UT_SmbBrowserUtils, CheckAndEnableService)
     EXPECT_TRUE(smb_browser_utils::checkAndEnableService("smbd"));
 
     serviceRunning = false;
-    bool startServiceResult = true;
-    stub.set_lamda(smb_browser_utils::startService, [&] { __DBG_STUB_INVOKE__ return startServiceResult; });
-    stub.set_lamda(smb_browser_utils::enableServiceAsync, [] { __DBG_STUB_INVOKE__ });
+    stub.set_lamda(smb_browser_utils::enableServiceNow, [] { return true; });
     EXPECT_TRUE(smb_browser_utils::checkAndEnableService("smb"));
 
-    startServiceResult = false;
     EXPECT_FALSE(smb_browser_utils::checkAndEnableService("sb"));
 }
 

autotests/services/sharecontrol/test_sharecontrol.cpp

@@ -34,18 +34,18 @@ class UT_ShareControlDBus : public testing::Test
     {
         // Reset read call counter for each test
         readCallCount = 0;
-        
+
         // Mock QDBusContext::message to prevent crashes
-        stub.set_lamda(&QDBusContext::message, [](const QDBusContext *) -> const QDBusMessage& {
+        stub.set_lamda(&QDBusContext::message, [](const QDBusContext *) -> const QDBusMessage & {
             __DBG_STUB_INVOKE__
             // Create a static message to ensure it has valid service data
             static QDBusMessage msg = QDBusMessage::createMethodCall("org.test.service", "/test", "org.test.Interface", "testMethod");
             return msg;
         });
-        
+
         shareControlDBus = new ShareControlDBus("test_sharecontrol");
     }
-    
+
     virtual void TearDown() override
     {
         stub.clear();
@@ -56,7 +56,7 @@ class UT_ShareControlDBus : public testing::Test
 protected:
     ShareControlDBus *shareControlDBus = nullptr;
     stub_ext::StubExt stub;
-    int readCallCount = 0;  // Track read system call count
+    int readCallCount = 0;   // Track read system call count
 };
 
 class UT_PolicyKitHelper : public testing::Test
@@ -278,13 +278,13 @@ TEST_F(UT_ShareControlDBus, SetUserSharePassword_Success_ReturnsTrue)
     stub.set_lamda(read, [this](int, void *buf, size_t count) -> ssize_t {
         __DBG_STUB_INVOKE__
         this->readCallCount++;
-        
+
         if (this->readCallCount == 1) {
             // First call: return serialized credentials data
             QByteArray data;
             QDataStream stream(&data, QIODevice::WriteOnly);
             stream << QString("testuser") << QString("testpassword");
-            
+
             // Copy data to buffer (ensure we don't exceed buffer size)
             size_t dataSize = std::min(static_cast<size_t>(data.size()), count);
             memcpy(buf, data.constData(), dataSize);
@@ -332,44 +332,6 @@ TEST_F(UT_ShareControlDBus, SetUserSharePassword_Success_ReturnsTrue)
     EXPECT_TRUE(result);
 }
 
-// Test EnableSmbServices with authentication failure
-TEST_F(UT_ShareControlDBus, EnableSmbServices_AuthenticationFailed_ReturnsFalse)
-{
-    // Mock authentication failure
-    stub.set_lamda(&PolicyKitHelper::checkAuthorization, [](PolicyKitHelper *, const QString &, const QString &) {
-        __DBG_STUB_INVOKE__
-        return false;
-    });
-
-    bool result = shareControlDBus->EnableSmbServices();
-    EXPECT_FALSE(result);
-}
-
-// Test EnableSmbServices successful execution
-TEST_F(UT_ShareControlDBus, EnableSmbServices_Success_ReturnsTrue)
-{
-    // Mock successful authentication
-    stub.set_lamda(&PolicyKitHelper::checkAuthorization, [](PolicyKitHelper *, const QString &, const QString &) {
-        __DBG_STUB_INVOKE__
-        return true;
-    });
-
-    // Mock QProcess success for both services - use function pointer to specify overload
-    using ProcessStartFunc = void (QProcess::*)(const QString &, const QStringList &, QIODevice::OpenMode);
-    stub.set_lamda(static_cast<ProcessStartFunc>(&QProcess::start), [](QProcess *, const QString &, const QStringList &, QIODevice::OpenMode) {
-        __DBG_STUB_INVOKE__
-    });
-
-    using ProcessWaitFunc = bool (QProcess::*)(int);
-    stub.set_lamda(static_cast<ProcessWaitFunc>(&QProcess::waitForFinished), [](QProcess *, int) {
-        __DBG_STUB_INVOKE__
-        return true;
-    });
-
-    bool result = shareControlDBus->EnableSmbServices();
-    EXPECT_TRUE(result);
-}
-
 // Test IsUserSharePasswordSet with process failure
 TEST_F(UT_ShareControlDBus, IsUserSharePasswordSet_ProcessFailed_ReturnsFalse)
 {