Skip to content

Commit f7e3e48

Browse files
committed
fix: add missing retry check in trash file operation
Added checkRetry() call in doMoveToTrash() function to properly handle retry logic during trash file operations. This ensures consistent behavior with the rest of the file operations workflow where retry attempts are properly evaluated before continuing with subsequent actions. Log: Fixed missing retry check in trash file operations Influence: 1. Test moving files to trash with insufficient permissions 2. Verify retry mechanism works properly during trash operations 3. Check skip and cancel operations still function correctly 4. Test with various error scenarios that would trigger retry fix: 添加回收站文件操作中缺失的重试检查 在doMoveToTrash()函数中添加了checkRetry()调用,以正确处理回收站文件操作 中的重试逻辑。这确保了与文件操作流程其他部分的一致性,即在继续后续操作之 前正确评估重试尝试。 Log: 修复回收站文件操作中缺失的重试检查 Influence: 1. 测试在权限不足时移动文件到回收站的情况 2. 验证回收站操作中重试机制正常工作 3. 检查跳过和取消操作仍能正常运行 4. 测试会触发重试的各种错误场景
1 parent bbc9478 commit f7e3e48

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/plugins/common/dfmplugin-fileoperations/fileoperations/trashfiles/domovetotrashfilesworker.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,8 @@ bool DoMoveToTrashFilesWorker::doMoveToTrash()
160160
}
161161
} while (action == AbstractJobHandler::SupportAction::kRetryAction && !isStopped());
162162

163+
checkRetry();
164+
163165
if (action == AbstractJobHandler::SupportAction::kNoAction
164166
|| action == AbstractJobHandler::SupportAction::kSkipAction
165167
|| action == AbstractJobHandler::SupportAction::kPermanentlyDelete) {

0 commit comments

Comments
 (0)