- 
                Notifications
    
You must be signed in to change notification settings  - Fork 201
 
Data channel reliability #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    cloudwebrtc
  
              
              approved these changes
              
                  
                    Sep 23, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
commit 05c712c Author: Hiroshi Horie <[email protected]> Date: Fri Sep 26 23:33:53 2025 +0800 Test commit 6e3bcd2 Merge: d3e165e a4871f5 Author: Hiroshi Horie <[email protected]> Date: Fri Sep 26 23:17:31 2025 +0800 Merge branch 'main' into hiroshi/fix-stream-progress commit d3e165e Author: Hiroshi Horie <[email protected]> Date: Fri Sep 26 23:16:44 2025 +0800 Merge main into hiroshi/fix-stream-progress Resolve conflicts by adopting enum-based TextStreamOperationType approach: - Use TextStreamOperationType.fromPBType() for incoming streams - Keep enum type for TextStreamInfo.operationType - Update protocol conversion to use .toPBType() - Maintain consistency with main branch enum approach commit a4c0e45 Author: Hiroshi Horie <[email protected]> Date: Tue Sep 23 04:36:01 2025 +0800 Fix stream progress commit 3053e14 Author: Hiroshi Horie <[email protected]> Date: Tue Sep 23 04:27:27 2025 +0800 Enum for TextStreamOperationType commit b361085 Author: Hiroshi Horie <[email protected]> Date: Tue Sep 23 04:15:31 2025 +0800 Implementation
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
No description provided.