From 3f95664c441c3f16f1140f7156057b8754de80cb Mon Sep 17 00:00:00 2001 From: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Sat, 25 Jan 2025 18:27:33 +0900 Subject: [PATCH 1/2] Create api-changes.yaml --- .github/workflows/api-changes.yaml | 51 ++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 .github/workflows/api-changes.yaml diff --git a/.github/workflows/api-changes.yaml b/.github/workflows/api-changes.yaml new file mode 100644 index 000000000..ba646bd48 --- /dev/null +++ b/.github/workflows/api-changes.yaml @@ -0,0 +1,51 @@ +name: Detect Public API changes + +on: + workflow_dispatch: + push: + branches: [main] + pull_request: + branches: [main] + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + build: + runs-on: macos-15 + timeout-minutes: 30 + + steps: + - uses: actions/checkout@v4 + + - name: Define Diff Versions + run: | + NEW="${{ env.source }}~${{ env.headGithubRepo }}" + OLD="${{ env.target }}~${{ env.baseGithubRepo }}" + + if [[ '${{ env.targetBranchName || env.noTargetBranch }}' == release/* ]] + then + LATEST_TAG=$(git describe --tags --abbrev=0) + OLD="$LATEST_TAG~${{ env.baseGithubRepo }}" + fi + + # Providing the output to the environment + echo "OLD_VERSION=$OLD" >> $GITHUB_ENV + echo "NEW_VERSION=$NEW" >> $GITHUB_ENV + env: + source: "${{ github.event.inputs.new || github.head_ref }}" + target: "${{ github.event.inputs.old || github.event.pull_request.base.ref }}" + headGithubRepo: "${{github.server_url}}/${{ github.event.pull_request.head.repo.full_name || github.repository}}.git" + baseGithubRepo: "${{github.server_url}}/${{github.repository}}.git" + noTargetBranch: "no target branch" + targetBranchName: "${{ github.head_ref }}" + + # The github action automatically posts on a PR (if it's not a fork-PR) + # and/or outputs the diff to the $GITHUB_STEP_SUMMARY + - name: Detect Changes + uses: Adyen/adyen-swift-public-api-diff@0.8.1 + with: + platform: "iOS" + new: ${{ env.NEW_VERSION }} + old: ${{ env.OLD_VERSION }} From 802ced4060293163b05a1ed1eb2e14d50683d2f7 Mon Sep 17 00:00:00 2001 From: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com> Date: Sat, 25 Jan 2025 18:46:48 +0900 Subject: [PATCH 2/2] Test break --- Sources/LiveKit/Core/Room.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Sources/LiveKit/Core/Room.swift b/Sources/LiveKit/Core/Room.swift index 96ed89908..3bc49f046 100644 --- a/Sources/LiveKit/Core/Room.swift +++ b/Sources/LiveKit/Core/Room.swift @@ -53,8 +53,8 @@ public class Room: NSObject, ObservableObject, Loggable { public var serverRegion: String? { _state.serverInfo?.region.nilIfEmpty } /// Region code the client is currently connected to. - @objc - public var serverNodeId: String? { _state.serverInfo?.nodeID.nilIfEmpty } + // @objc + // public var serverNodeId: String? { _state.serverInfo?.nodeID.nilIfEmpty } @objc public var remoteParticipants: [Participant.Identity: RemoteParticipant] { _state.remoteParticipants }