Skip to content

Conversation

@huacnlee
Copy link
Member

@huacnlee huacnlee commented Jun 19, 2025

Wait zed-industries/zed#33008, zed-industries/zed#34804 to merge.

Screen.Recording.2025-07-22.at.19.08.25.mov
  • Improved focus_ring to render like an outline.
  • Added to support press Enter, Space key to trigger Checkbox, Button, Radio.

Break Changes

  • The FocusableExt has been changed to only for crate internal.
  • The FocusableCycle has been removed, now GPUI has it own tab stop implementation.

@huacnlee huacnlee changed the title New tab, shift-tab to cycle focus. Refactor tab key to switch focus. Jun 19, 2025
@stormasm
Copy link
Contributor

Its amazing how important it is to be developing a real world project like
gpui-component to make significant progress in the gpui crate.

Your new work with zed-industries/zed#33008 shows the significance of this !

Also the work with the chart / plot in concert with zed-industries/zed#30904 is another great example !

@huacnlee huacnlee changed the title Refactor tab key to switch focus. chore: Refactor tab key to switch focus. Jul 21, 2025
@huacnlee huacnlee marked this pull request as ready for review July 21, 2025 05:46
@huacnlee huacnlee merged commit 5e504d1 into main Sep 29, 2025
3 checks passed
@huacnlee huacnlee deleted the tab-index branch September 29, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants