Merge pull request #5 from macadmins/fix_plist_unit_test

Embed a binary plist

Author: grahamgilbert

pkg/launchservices/binary_data.plist

@@ -56,13 +56,12 @@ func ReadPlist(path string) (Plist, error) {
 	if err != nil {
 		return p, err
 	}
-	plistFile, err := os.Open(path)
+	data, err := os.ReadFile(path)
 	if err != nil {
 		return p, err
 	}
-	defer plistFile.Close()
 
-	err = plist.NewBinaryDecoder(plistFile).Decode(&p)
+	err = plist.Unmarshal(data, &p)
 	if err != nil {
 		return p, err
 	}

pkg/launchservices/plist.go

@@ -5,33 +5,21 @@ import (
 	"path/filepath"
 	"testing"
 
+	_ "embed"
+
 	"github.com/stretchr/testify/assert"
 )
 
+//go:embed binary_data.plist
+var binaryplist []byte
+
 func TestReadPlist(t *testing.T) {
 	// Create a temporary file with fake plist data
 	tmpfile, err := os.CreateTemp("", "test.plist")
 	assert.NoError(t, err, "TempFile should not return an error")
 	defer os.Remove(tmpfile.Name())
 
-	fakePlistData := `
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-    <key>LSHandlers</key>
-    <array>
-        <dict>
-            <key>LSHandlerContentType</key>
-            <string>public.html</string>
-            <key>LSHandlerRoleAll</key>
-            <string>com.apple.safari</string>
-        </dict>
-    </array>
-</dict>
-</plist>
-`
-	_, err = tmpfile.Write([]byte(fakePlistData))
+	_, err = tmpfile.Write([]byte(binaryplist))
 	assert.NoError(t, err, "Write should not return an error")
 	err = tmpfile.Close()
 	assert.NoError(t, err, "Close should not return an error")