Skip to content

Commit 87072ef

Browse files
committed
Overriding the problem with c/c requires C99 with older GCC
Fixing issue of lately added tests with old UnixODBC versions
1 parent fc52d66 commit 87072ef

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ SET(MARIADB_ODBC_VERSION_PATCH 19)
3434
SET(MARIADB_ODBC_VERSION_QUALITY "ga")
3535

3636
SET(MARIADB_ODBC_VERSION "03.01.0019")
37+
IF(CMAKE_VERSION VERSION_LESS "3.1")
38+
IF(CMAKE_C_COMPILER_ID STREQUAL "GNU")
39+
SET (CMAKE_C_FLAGS ${CMAKE_C_FLAGS} "-std=gnu99 ${CMAKE_C_FLAGS}")
40+
ENDIF()
41+
ELSE()
42+
SET(CMAKE_C_STANDARD 99)
43+
endif()
3744

3845
SET(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_SOURCE_DIR}/cmake)
3946

test/basic.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,6 +1189,7 @@ ODBC_TEST(t_bug44971)
11891189
OK_SIMPLE_STMT(Stmt, "DROP DATABASE IF EXISTS bug44971");
11901190
OK_SIMPLE_STMT(Stmt, "CREATE DATABASE bug44971");
11911191
CHECK_DBC_RC(Connection, SQLGetConnectAttr(Connection, SQL_ATTR_CURRENT_CATALOG, buffer, sizeof(buffer), &len));
1192+
CHECK_STMT_RC(Stmt, SQLFreeStmt(Stmt, SQL_CLOSE));
11921193
CHECK_DBC_RC(Connection, SQLSetConnectAttr(Connection, SQL_ATTR_CURRENT_CATALOG, "bug44971xxx", 8));
11931194
/* Restoring original schema back. This also covers ODBC-392. Somehow it always hits here, but not in the previous line */
11941195
CHECK_DBC_RC(Connection, SQLSetConnectAttr(Connection, SQL_ATTR_CURRENT_CATALOG, buffer, len));

test/catalog2.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1891,6 +1891,7 @@ ODBC_TEST(odbc391)
18911891
OK_SIMPLE_STMT(Stmt, "DROP SCHEMA IF EXISTS _SchemaOdbc391");
18921892
OK_SIMPLE_STMT(Stmt, "CREATE SCHEMA _SchemaOdbc391");
18931893
CHECK_DBC_RC(Connection, SQLGetConnectAttr(Connection, SQL_ATTR_CURRENT_CATALOG, buffer, sizeof(buffer), &len));
1894+
CHECK_STMT_RC(Stmt, SQLFreeStmt(Stmt, SQL_CLOSE));
18941895
CHECK_DBC_RC(Connection, SQLSetConnectAttr(Connection, SQL_ATTR_CURRENT_CATALOG, (SQLPOINTER)"_SchemaOdbc391", 14));
18951896
CHECK_STMT_RC(Stmt, SQLTables(Stmt, (SQLCHAR*)SQL_ALL_CATALOGS, 1, "", 0, "", 0, NULL, 0));
18961897
while (SQLFetch(Stmt) != SQL_NO_DATA)
@@ -1927,7 +1928,7 @@ ODBC_TEST(odbc391)
19271928
EXPECT_STMT(Stmt, SQLFetch(Stmt), SQL_NO_DATA);
19281929
CHECK_STMT_RC(Stmt, SQLFreeStmt(Stmt, SQL_CLOSE));
19291930

1930-
CHECK_STMT_RC(Stmt, SQLSpecialColumns(Stmt, SQL_ROWVER, dbname, (SQLSMALLINT)dbnameLen, NULL, SQL_NTS, tname, (SQLSMALLINT)tnameLen,
1931+
CHECK_STMT_RC(Stmt, SQLSpecialColumns(Stmt, SQL_ROWVER, dbname, (SQLSMALLINT)dbnameLen, NULL, 0, tname, (SQLSMALLINT)tnameLen,
19311932
SQL_SCOPE_TRANSACTION, SQL_NULLABLE));
19321933
CHECK_STMT_RC(Stmt, SQLFetch(Stmt));
19331934
EXPECT_STMT(Stmt, SQLFetch(Stmt), SQL_NO_DATA);

0 commit comments

Comments
 (0)