fix (menu): apply external class to external links in menu

brysonbw · brysonbw · commit 579829b5cca3 · 2025-10-23T19:50:53.000-06:00
diff --git a/components/menu/server.js b/components/menu/server.js
@@ -107,8 +107,10 @@ export class Menu extends ServerComponent {
                                         class=${ifDefined(
                                           [
                                             item.icon && "menu__panel-icon",
-                                            context.locale !== "en-US" &&
-                                              "only-in-en-us",
+                                            (!item.href.startsWith("/") &&
+                                              "external") ||
+                                              (context.locale !== "en-US" &&
+                                                "only-in-en-us"),
                                           ]
                                             .filter(Boolean)
                                             .join(" "),

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,10 @@ export class Menu extends ServerComponent {`
`107`	`107`	`class=${ifDefined(`
`108`	`108`	`[`
`109`	`109`	`item.icon && "menu__panel-icon",`
`110`		`- context.locale !== "en-US" &&`
`111`		`- "only-in-en-us",`
	`110`	`+ (!item.href.startsWith("/") &&`
	`111`	`+ "external") \|\|`
	`112`	`+ (context.locale !== "en-US" &&`
	`113`	`+ "only-in-en-us"),`
`112`	`114`	`]`
`113`	`115`	`.filter(Boolean)`
`114`	`116`	`.join(" "),`