Skip to content

Commit a3d91fe

Browse files
committed
Ensure TEST_SUITE.request_time is in UTC
This fixes an issue with the time set by @freeze_time being different than the original test case request time.
1 parent d128dca commit a3d91fe

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/protocol_test_suite_helper.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# file to handle loading and parsing of mauth protocol test suite cases in order
22
# to run them as unit tests
33

4-
from datetime import datetime
4+
from datetime import datetime, timezone
55
import glob
66
import os
77
import json
@@ -29,7 +29,7 @@ def __init__(self):
2929
with open(os.path.join(MAUTH_PROTOCOL_DIR, "signing-params/rsa-key-pub"), "r") as key_file:
3030
self.public_key = key_file.read()
3131

32-
self.request_time = datetime.fromtimestamp(float(config["request_time"]))
32+
self.request_time = datetime.fromtimestamp(float(config["request_time"]), timezone.utc)
3333
self.app_uuid = config["app_uuid"]
3434
self.signer = Signer(config["app_uuid"], private_key, "v2")
3535
self.additional_attributes = {"app_uuid": config["app_uuid"], "time": config["request_time"]}
@@ -44,7 +44,7 @@ def __init__(self, case_path):
4444
self.request_attributes = self.build_request_attributes(case_path)
4545
self.sts = self.read_file_by_extension(case_path, "sts")
4646
self.sig = self.read_file_by_extension(case_path, "sig")
47-
self.auth_headers = self.read_json_by_extension(case_path, "authz")
47+
self.auth_headers = {k: str(v) for k, v in self.read_json_by_extension(case_path, "authz").items()}
4848

4949
def build_request_attributes(self, case_path):
5050
req = self.read_json_by_extension(case_path, "req")

tests/protocol_test_suite_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_protocol_test_suite(self):
2727
for case_path in TEST_SUITE.cases():
2828
parser = ProtocolTestSuiteParser(case_path)
2929
request_signable = RequestSignable(**parser.request_attributes)
30-
signed_headers_v2 = TEST_SUITE.signer.signed_headers_v2(request_signable, TEST_SUITE.additional_attributes)
30+
signed_headers_v2 = TEST_SUITE.signer.signed_headers_v2(request_signable)
3131
if "authentication-only" not in case_path:
3232
with self.subTest(test="string_to_sign_v2", case_name=parser.case_name):
3333
string_to_sign = request_signable.string_to_sign_v2(TEST_SUITE.additional_attributes)

0 commit comments

Comments
 (0)