change client interface and implementation names

Author: vallerion

client.go

@@ -46,9 +46,9 @@ type Client interface {
 	Request(v interface{}, method, path string, data interface{}) error
 }
 
-// BasicClient is used to access API with a given key.
+// DefaultClient is used to access API with a given key.
 // Uses standard lib HTTP client internally, so should be reused instead of created as needed and it is safe for concurrent use.
-type BasicClient struct {
+type DefaultClient struct {
 	AccessKey  string       // The API access key.
 	HTTPClient *http.Client // The HTTP client to send requests on.
 	DebugLog   *log.Logger  // Optional logger for debugging purposes.
@@ -73,8 +73,8 @@ func SetErrorReader(r errorReader) {
 }
 
 // New creates a new MessageBird client object.
-func New(accessKey string) *BasicClient {
-	return &BasicClient{
+func New(accessKey string) *DefaultClient {
+	return &DefaultClient{
 		AccessKey: accessKey,
 		HTTPClient: &http.Client{
 			Timeout: httpClientTimeout,
@@ -83,7 +83,7 @@ func New(accessKey string) *BasicClient {
 }
 
 // Request is for internal use only and unstable.
-func (c *BasicClient) Request(v interface{}, method, path string, data interface{}) error {
+func (c *DefaultClient) Request(v interface{}, method, path string, data interface{}) error {
 	if !strings.HasPrefix(path, "https://") && !strings.HasPrefix(path, "http://") {
 		path = fmt.Sprintf("%s/%s", Endpoint, path)
 	}

conversation/api.go

@@ -31,7 +31,7 @@ const (
 	webhooksPath = "webhooks"
 )
 
-// request does the exact same thing as BasicClient.Request. It does, however,
+// request does the exact same thing as DefaultClient.Request. It does, however,
 // prefix the path with the Conversation API's root. This ensures the client
 // doesn't "handle" this for us: by default, it uses the REST API.
 func request(c messagebird.Client, v interface{}, method, path string, data interface{}) error {

internal/mbtest/test_client.go

@@ -32,11 +32,11 @@ func MockClient() messagebird.Client {
 }
 
 // Client initializes a new MessageBird client that uses the
-func Client(t *testing.T) *messagebird.BasicClient {
+func Client(t *testing.T) *messagebird.DefaultClient {
 	return newClient(t, "")
 }
 
-func newClient(t *testing.T, accessKey string) *messagebird.BasicClient {
+func newClient(t *testing.T, accessKey string) *messagebird.DefaultClient {
 	transport := &http.Transport{
 		DialTLS: func(network, _ string) (net.Conn, error) {
 			addr := server.Listener.Addr().String()

number/number.go

@@ -311,7 +311,7 @@ func paramsForArrays(field string, values []string, urlParams *url.Values) {
 	}
 }
 
-// request does the exact same thing as BasicClient.Request. It does, however,
+// request does the exact same thing as DefaultClient.Request. It does, however,
 // prefix the path with the Numbers API's root. This ensures the client
 // doesn't "handle" this for us: by default, it uses the REST API.
 func request(c messagebird.Client, v interface{}, method, path string, data interface{}) error {

voice/main_test.go

@@ -12,7 +12,7 @@ import (
 	messagebird "github.com/messagebird/go-rest-api/v9"
 )
 
-func testRequest(status int, body []byte) (*messagebird.BasicClient, func()) {
+func testRequest(status int, body []byte) (*messagebird.DefaultClient, func()) {
 	mbServer := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(status)
@@ -33,12 +33,12 @@ func testRequest(status int, body []byte) (*messagebird.BasicClient, func()) {
 	return mbClient, func() { mbServer.Close() }
 }
 
-func testClient(t *testing.T) (*messagebird.BasicClient, bool) {
+func testClient(t *testing.T) (*messagebird.DefaultClient, bool) {
 	key, ok := os.LookupEnv("MB_TEST_KEY")
 	if !ok {
 		return nil, false
 	}
-	client := &messagebird.BasicClient{
+	client := &messagebird.DefaultClient{
 		AccessKey:  key,
 		HTTPClient: &http.Client{},
 		DebugLog:   log.New(testWriter{T: t}, "", 0),

voice/recording.go

@@ -115,7 +115,7 @@ func Delete(client messagebird.Client, callID, legID, recordingID string) error
 }
 
 // DownloadFile streams the recorded WAV file.
-func (rec *Recording) DownloadFile(client *messagebird.BasicClient) (io.ReadCloser, error) {
+func (rec *Recording) DownloadFile(client *messagebird.DefaultClient) (io.ReadCloser, error) {
 	req, err := http.NewRequest(http.MethodGet, apiRoot+rec.Links["file"], nil)
 	if err != nil {
 		return nil, err

voice/transcription.go

@@ -70,7 +70,7 @@ func (trans *Transcription) UnmarshalJSON(data []byte) error {
 // Contents gets the transcription file.
 //
 // This is a plain text file.
-func (trans *Transcription) Contents(client *messagebird.BasicClient) (string, error) {
+func (trans *Transcription) Contents(client *messagebird.DefaultClient) (string, error) {
 	req, err := http.NewRequest(http.MethodGet, apiRoot+trans.links["file"], nil)
 	if err != nil {
 		return "", err