[hyperactor] assert_behaves! #1826
Open
+41
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior: ``` hyperactor::assert_behaves!(TestMeshController as Controller<TestMesh>); ``` It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly. (We already statically validate this at the *use* site, but then the errors are already "at a distance".) Differential Revision: [D86786231](https://our.internmc.facebook.com/intern/diff/D86786231/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86786231/)! [ghstack-poisoned]
This was referenced Nov 11, 2025
mariusae
added a commit
that referenced
this pull request
Nov 11, 2025
This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior: ``` hyperactor::assert_behaves!(TestMeshController as Controller<TestMesh>); ``` It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly. (We already statically validate this at the *use* site, but then the errors are already "at a distance".) Differential Revision: [D86786231](https://our.internmc.facebook.com/intern/diff/D86786231/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86786231/)! ghstack-source-id: 322480874 Pull Request resolved: #1826
meta-cla
bot
added
the
CLA Signed
This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior: ``` hyperactor::assert_behaves!(TestMeshController as Controller<TestMesh>); ``` It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly. (We already statically validate this at the *use* site, but then the errors are already "at a distance".) Differential Revision: [D86786231](https://our.internmc.facebook.com/intern/diff/D86786231/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86786231/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 12, 2025
Pull Request resolved: #1826 This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior: ``` hyperactor::assert_behaves!(TestMeshController as Controller<TestMesh>); ``` It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly. (We already statically validate this at the *use* site, but then the errors are already "at a distance".) Differential Revision: [D86786231](https://our.internmc.facebook.com/intern/diff/D86786231/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86786231/)! ghstack-source-id: 322613843
This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior: ``` hyperactor::assert_behaves!(TestMeshController as Controller<TestMesh>); ``` It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly. (We already statically validate this at the *use* site, but then the errors are already "at a distance".) Differential Revision: [D86786231](https://our.internmc.facebook.com/intern/diff/D86786231/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86786231/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 12, 2025
Pull Request resolved: #1826 This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior: ``` hyperactor::assert_behaves!(TestMeshController as Controller<TestMesh>); ``` It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly. (We already statically validate this at the *use* site, but then the errors are already "at a distance".) ghstack-source-id: 322730453 Differential Revision: [D86786231](https://our.internmc.facebook.com/intern/diff/D86786231/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D86786231/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This adds a macro that asserts an actor's behavior; we use it to test the mesh behavior:
It is implemented by statically validating that the actor type can bind to the defined behavior. This then provide a way to both document the intended behavior of an actor, and also to statically validate at the definition site that the behavior is implemented correctly.
(We already statically validate this at the use site, but then the errors are already "at a distance".)
Differential Revision: D86786231
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!