Skip to content

Commit 49ab01f

Browse files
author
Daniel Flores
committed
add testing todo
1 parent 68b9de6 commit 49ab01f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/torchcodec/_core/Encoder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,7 @@ UniqueAVFrame VideoEncoder::convertTensorToAVFrame(
725725
// TODO-VideoEncoder: Reorder tensor if in NHWC format
726726
int channelSize = inHeight_ * inWidth_;
727727
// Reorder RGB -> GBR for AV_PIX_FMT_GBRP format
728-
// TODO-VideoEncoder: Determine if FFmpeg supports RGB input format directly
728+
// TODO-VideoEncoder: Determine if FFmpeg supports planar RGB input format
729729
inputFrame->data[0] = tensorData + channelSize;
730730
inputFrame->data[1] = tensorData + (2 * channelSize);
731731
inputFrame->data[2] = tensorData;

test/test_ops.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1267,6 +1267,7 @@ def decode(self, file_path) -> torch.Tensor:
12671267
@pytest.mark.parametrize("format", ("mov", "mp4", "avi"))
12681268
# TODO-VideoEncoder: enable additional formats (mkv, webm)
12691269
def test_video_encoder_test_round_trip(self, tmp_path, format):
1270+
# TODO-VideoEncoder: Test with FFmpeg's testsrc2 video
12701271
asset = NASA_VIDEO
12711272

12721273
# Test that decode(encode(decode(asset))) == decode(asset)

0 commit comments

Comments
 (0)