From ca7a64f4d2b7792b3cb8704c474f8560a1265b54 Mon Sep 17 00:00:00 2001 From: Nielsbishere Date: Wed, 28 Aug 2024 22:45:36 +0200 Subject: [PATCH 1/2] Update d3d12shader.h At the very least, that's what DXC outputs. Unsure if FXC has the same behavior, but it seems flipped. --- include/directx/d3d12shader.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/directx/d3d12shader.h b/include/directx/d3d12shader.h index 65728dd..54b3760 100644 --- a/include/directx/d3d12shader.h +++ b/include/directx/d3d12shader.h @@ -169,7 +169,7 @@ typedef struct _D3D12_SHADER_INPUT_BIND_DESC UINT uFlags; // Input binding flags D3D_RESOURCE_RETURN_TYPE ReturnType; // Return type (if texture) D3D_SRV_DIMENSION Dimension; // Dimension (if texture) - UINT NumSamples; // Number of samples (0 if not MS texture) + UINT NumSamples; // Number of samples (0 if MS texture, UINT_MAX otherwise) UINT Space; // Register space UINT uID; // Range ID in the bytecode } D3D12_SHADER_INPUT_BIND_DESC; From aa0f15fb9a5ef055e70daf9577096e0d2cf89cb5 Mon Sep 17 00:00:00 2001 From: Nielsbishere Date: Mon, 9 Dec 2024 22:07:55 +0100 Subject: [PATCH 2/2] Update d3d12shader.h --- include/directx/d3d12shader.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/directx/d3d12shader.h b/include/directx/d3d12shader.h index 54b3760..f0f1966 100644 --- a/include/directx/d3d12shader.h +++ b/include/directx/d3d12shader.h @@ -169,7 +169,7 @@ typedef struct _D3D12_SHADER_INPUT_BIND_DESC UINT uFlags; // Input binding flags D3D_RESOURCE_RETURN_TYPE ReturnType; // Return type (if texture) D3D_SRV_DIMENSION Dimension; // Dimension (if texture) - UINT NumSamples; // Number of samples (0 if MS texture, UINT_MAX otherwise) + UINT NumSamples; // Number of samples or stride (stride if sbuffer, 0 if buffer, [0, 32] samples if MS texture otherwise UINT_MAX) UINT Space; // Register space UINT uID; // Range ID in the bytecode } D3D12_SHADER_INPUT_BIND_DESC;