Get Cocoapods build building for test targets, make macOS API surface equivalent to iOS and Android (#305)

* Update scripts to publish react-native-macos-init

* Clean up merge markers

* Restored ios:macos RNTester parity except for InputAccessoryView.

* Add InputAccessoryView for mac

* iOS tests pass via Pods

* IntegrationTests passing

* All targets building

* Removed unused file.

* Preserve building in both static xcodeproj and cocoapods.

* Missed a diff comment

* Elliminstated RCTTest #ifdefs

* Align with upstream changes post .60

* Fix Flow check and minor ESLint whitespace

* Make .gitignore align with changes upstream.

Author: tom-un

.gitignore

@@ -41,6 +41,11 @@ buck-out
 /ReactAndroid/src/main/jni/prebuilt/lib/x86/
 /ReactAndroid/src/main/gen
 
+# Android Studio
+.project
+.settings
+.classpath
+
 # Watchman
 .watchmanconfig
 

Libraries/Blob/React-RCTBlob.podspec

@@ -28,7 +28,7 @@ Pod::Spec.new do |s|
   s.source                 = source
   s.source_files           = "*.{h,m,mm}"
   s.preserve_paths         = "package.json", "LICENSE", "LICENSE-docs"
-  s.header_dir             = "React"
+  s.header_dir             = "RCTBlob"
 
   s.dependency "React-Core", version
   s.dependency "React-RCTNetwork", version

Libraries/CameraRoll/RCTCameraRollManager.m

@@ -9,11 +9,13 @@
 
 #import <CoreLocation/CoreLocation.h>
 #import <Foundation/Foundation.h>
-#import <UIKit/UIKit.h>
+#import <React/RCTUIKit.h> // TODO(macOS ISS#2323203)
 #import <Photos/Photos.h>
 #import <dlfcn.h>
 #import <objc/runtime.h>
+#if !TARGET_OS_OSX // TODO(macOS ISS#2323203)
 #import <MobileCoreServices/UTType.h>
+#endif // TODO(macOS ISS#2323203)
 
 #import <React/RCTBridge.h>
 #import <React/RCTConvert.h>
@@ -318,6 +320,7 @@ static void RCTResolvePromise(RCTPromiseResolveBlock resolve,
                   resolve:(RCTPromiseResolveBlock)resolve
                   reject:(RCTPromiseRejectBlock)reject)
 {
+#if !TARGET_OS_OSX // TODO(macOS ISS#2323203)
   NSArray<NSURL *> *assets_ = [RCTConvert NSURLArray:assets];
   [[PHPhotoLibrary sharedPhotoLibrary] performChanges:^{
       PHFetchResult<PHAsset *> *fetched =
@@ -333,6 +336,10 @@ static void RCTResolvePromise(RCTPromiseResolveBlock resolve,
       }
     }
     ];
+#else // [TODO(macOS ISS#2323203)
+	NSError *error = RCTErrorWithMessage(@"Delete image not available on macOS");
+	reject(@"Couldn't delete", @"Couldn't delete assets", error);
+#endif // ]TODO(macOS ISS#2323203)
 }
 
 static void checkPhotoLibraryConfig()

Libraries/CameraRoll/RCTPhotoLibraryImageLoader.m

@@ -45,9 +45,11 @@ - (RCTImageLoaderCancellationBlock)loadImageForURL:(NSURL *)imageURL
   if (!imageURL) {
     completionHandler(RCTErrorWithMessage(@"Cannot load a photo library asset with no URL"), nil);
     return ^{};
+#if !TARGET_OS_OSX // TODO(macOS ISS#2323203)
   } else if ([imageURL.scheme caseInsensitiveCompare:@"assets-library"] == NSOrderedSame) {
     assetID = [imageURL absoluteString];
     results = [PHAsset fetchAssetsWithALAssetURLs:@[imageURL] options:nil];
+#endif // TODO(macOS ISS#2323203)
   } else {
     assetID = [imageURL.absoluteString substringFromIndex:@"ph://".length];
     results = [PHAsset fetchAssetsWithLocalIdentifiers:@[assetID] options:nil];

Libraries/CameraRoll/React-RCTCameraRoll.podspec

@@ -25,12 +25,15 @@ Pod::Spec.new do |s|
   s.documentation_url      = "https://facebook.github.io/react-native/docs/cameraroll"
   s.license                = package["license"]
   s.author                 = "Facebook, Inc. and its affiliates"
-  s.platforms              = { :ios => "9.0", :tvos => "9.2" }
+  s.platforms              = { :ios => "9.0", :tvos => "9.2", :osx => "10.14" } # TODO(macOS GH#214)
   s.source                 = source
   s.source_files           = "*.{h,m}"
   s.preserve_paths         = "package.json", "LICENSE", "LICENSE-docs"
   s.header_dir             = "React"
 
   s.dependency "React-Core", version
   s.dependency "React-RCTImage", version
+
+  s.osx.exclude_files      = "RCTImagePickerManager.*", "RCTAssetsLibraryRequestHandler.*" # TODO(macOS GH#214)
+
 end

Libraries/Image/RCTImageView.h

@@ -37,4 +37,16 @@ typedef NS_ENUM(NSInteger, UIImageRenderingMode) {
 @property (nonatomic, assign) CGFloat blurRadius;
 @property (nonatomic, assign) RCTResizeMode resizeMode;
 
+#if TARGET_OS_OSX // [TODO(macOS ISS#2323203)
+/**
+ * macOS Properties
+ */
+@property (nonatomic, copy) RCTDirectEventBlock onDoubleClick;
+@property (nonatomic, copy) RCTDirectEventBlock onClick;
+@property (nonatomic, copy) RCTDirectEventBlock onMouseEnter;
+@property (nonatomic, copy) RCTDirectEventBlock onMouseLeave;
+@property (nonatomic, copy) RCTDirectEventBlock onDragEnter;
+@property (nonatomic, copy) RCTDirectEventBlock onDragLeave;
+@property (nonatomic, copy) RCTDirectEventBlock onDrop;
+#endif // ]TODO(macOS ISS#2323203)
 @end

Libraries/NativeAnimation/React-RCTAnimation.podspec

@@ -28,7 +28,7 @@ Pod::Spec.new do |s|
   s.source                 = source
   s.source_files           = "{Drivers/*,Nodes/*,*}.{h,m}"
   s.preserve_paths         = "package.json", "LICENSE", "LICENSE-docs"
-  s.header_dir             = "React"
+  s.header_dir             = "RCTAnimation"
 
   s.dependency "React-Core", version
 end

Libraries/Text/React-RCTText.podspec

@@ -32,6 +32,4 @@ Pod::Spec.new do |s|
   s.header_dir             = "React"
 
   s.dependency "React-Core", version
-
-  s.osx.exclude_files      = "TextInput/RCTInputAccessory{,Shadow}View*.{h,m}"
 end

Libraries/Text/TextInput/RCTInputAccessoryShadowView.m

@@ -14,7 +14,9 @@ @implementation RCTInputAccessoryShadowView
 - (void)insertReactSubview:(RCTShadowView *)subview atIndex:(NSInteger)atIndex
 {
   [super insertReactSubview:subview atIndex:atIndex];
+#if !TARGET_OS_OSX // TODO(macOS ISS#2323203)
   subview.width = (YGValue) { RCTScreenSize().width, YGUnitPoint };
+#endif // TODO(macOS ISS#2323203)
 }
 
 @end

Libraries/Text/TextInput/RCTInputAccessoryView.m

@@ -16,7 +16,7 @@
 @interface RCTInputAccessoryView()
 
 // Overriding `inputAccessoryView` to `readwrite`.
-@property (nonatomic, readwrite, retain) UIView *inputAccessoryView;
+@property (nonatomic, readwrite, retain) RCTUIView *inputAccessoryView; // TODO(macOS ISS#2323203)
 
 @end
 
@@ -50,13 +50,13 @@ - (void)reactSetFrame:(CGRect)frame
   }
 }
 
-- (void)insertReactSubview:(UIView *)subview atIndex:(NSInteger)index
+- (void)insertReactSubview:(RCTUIView *)subview atIndex:(NSInteger)index  // TODO(macOS ISS#2323203)
 {
   [super insertReactSubview:subview atIndex:index];
   [_inputAccessoryView insertReactSubview:subview atIndex:index];
 }
 
-- (void)removeReactSubview:(UIView *)subview
+- (void)removeReactSubview:(RCTUIView *)subview // TODO(macOS ISS#2323203)
 {
   [super removeReactSubview:subview];
   [_inputAccessoryView removeReactSubview:subview];