chore(template): dynamically resolve node modules root #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonVMo
approved these changes
Nov 10, 2025
tido64
reviewed
Nov 11, 2025
| require 'pathname' | ||
|
|
||
| modules_root = Pathname.new(__dir__).parent | ||
| modules_root = modules_root.parent until modules_root.join('node_modules').directory? || modules_root.root? |
Member
There was a problem hiding this comment.
This is just going to find the first node_modules folder. react-native-macos and @react-native-community/cli-platform-ios might resolve to different ones.
Collaborator
Author
There was a problem hiding this comment.
It occurred to me that the template ships with RNM, not our init command, so we can just assume the legacy script is no longer there for 0.75+, and I don't need to check for both
tido64
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Followup from #2756 (comment)