Skip to content

Commit a641e82

Browse files
authored
fix(android): rename the root package from com.sample to com.react.testapp (#137)
* fix(android): rename the root package from com.sample to com.react.testapp
1 parent d659070 commit a641e82

File tree

18 files changed

+40
-39
lines changed

18 files changed

+40
-39
lines changed

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ apply plugin: "kotlin-kapt"
3232
def testAppDir = file("$projectDir/../../")
3333

3434
apply from: file("${testAppDir}/test-app.gradle")
35-
applyTestAppModule(project, "com.sample")
35+
applyTestAppModule(project, "com.react.testapp")
3636

3737
project.ext.react = [
3838
enableFlipper: getFlipperVersion(rootDir),
@@ -51,7 +51,7 @@ android {
5151
}
5252

5353
defaultConfig {
54-
applicationId "com.sample"
54+
applicationId "com.react.testapp"
5555
minSdkVersion 21
5656
targetSdkVersion 29
5757
versionCode 1

android/app/src/androidTest/java/com/sample/ExampleInstrumentedTest.kt renamed to android/app/src/androidTest/java/com/react/testapp/ExampleInstrumentedTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.sample
1+
package com.react.testapp
22

33
import androidx.test.platform.app.InstrumentationRegistry
44
import androidx.test.ext.junit.runners.AndroidJUnit4
@@ -14,6 +14,6 @@ class ExampleInstrumentedTest {
1414
@Test
1515
fun useAppContext() {
1616
val appContext = InstrumentationRegistry.getInstrumentation().targetContext
17-
assertEquals("com.sample", appContext.packageName)
17+
assertEquals("com.react.testapp", appContext.packageName)
1818
}
1919
}

android/app/src/flipper/java/com/sample/react/ReactNativeFlipper.kt renamed to android/app/src/flipper/java/com/react/testapp/ReactNativeFlipper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.sample.react
1+
package com.react.testapp
22

33
import android.content.Context
44
import com.facebook.flipper.android.AndroidFlipperClient

android/app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
4-
package="com.sample">
4+
package="com.react.testapp">
55

66
<uses-permission android:name="android.permission.INTERNET" />
77

@@ -18,14 +18,14 @@
1818

1919
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
2020

21-
<activity android:name=".MainActivity">
21+
<activity android:name="com.react.testapp.MainActivity">
2222
<intent-filter>
2323
<action android:name="android.intent.action.MAIN" />
2424
<category android:name="android.intent.category.LAUNCHER" />
2525
</intent-filter>
2626
</activity>
2727

28-
<activity android:name=".component.ComponentActivity" />
28+
<activity android:name="com.react.testapp.component.ComponentActivity" />
2929
</application>
3030

3131
</manifest>

android/app/src/main/java/com/sample/MainActivity.kt renamed to android/app/src/main/java/com/react/testapp/MainActivity.kt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.sample
1+
package com.react.testapp
22

33
import android.os.Bundle
44
import android.view.LayoutInflater
@@ -9,14 +9,15 @@ import androidx.recyclerview.widget.RecyclerView
99
import com.facebook.react.ReactActivity
1010
import com.facebook.react.modules.systeminfo.ReactNativeVersion
1111
import com.google.android.material.appbar.MaterialToolbar
12-
import com.sample.component.ComponentActivity
13-
import com.sample.component.ComponentListAdapter
14-
import com.sample.component.ComponentViewModel
15-
import com.sample.manifest.Component
16-
import com.sample.manifest.ManifestProvider
17-
import com.sample.react.BundleSource
18-
import com.sample.react.ReactBundleNameProvider
19-
import com.sample.react.TestAppReactNativeHost
12+
import com.react.testapp.R
13+
import com.react.testapp.component.ComponentActivity
14+
import com.react.testapp.component.ComponentListAdapter
15+
import com.react.testapp.component.ComponentViewModel
16+
import com.react.testapp.manifest.Component
17+
import com.react.testapp.manifest.ManifestProvider
18+
import com.react.testapp.react.BundleSource
19+
import com.react.testapp.react.ReactBundleNameProvider
20+
import com.react.testapp.react.TestAppReactNativeHost
2021
import dagger.android.AndroidInjection
2122
import javax.inject.Inject
2223

android/app/src/main/java/com/sample/TestApp.kt renamed to android/app/src/main/java/com/react/testapp/TestApp.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package com.sample
1+
package com.react.testapp
22

33
import android.app.Application
44
import com.facebook.react.ReactApplication
5-
import com.sample.di.DaggerTestAppComponent
6-
import com.sample.react.TestAppReactNativeHost
5+
import com.react.testapp.di.DaggerTestAppComponent
6+
import com.react.testapp.react.TestAppReactNativeHost
77
import dagger.android.AndroidInjector
88
import dagger.android.DispatchingAndroidInjector
99
import dagger.android.HasAndroidInjector

android/app/src/main/java/com/sample/component/ComponentActivity.kt renamed to android/app/src/main/java/com/react/testapp/component/ComponentActivity.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.sample.component
1+
package com.react.testapp.component
22

33
import android.app.Activity
44
import android.content.Intent

android/app/src/main/java/com/sample/component/ComponentListAdapter.kt renamed to android/app/src/main/java/com/react/testapp/component/ComponentListAdapter.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
package com.sample.component
1+
package com.react.testapp.component
22

33
import android.view.LayoutInflater
44
import android.view.ViewGroup
55
import android.widget.TextView
66
import androidx.recyclerview.widget.RecyclerView
7-
import com.sample.R
7+
import com.react.testapp.R
88

99
class ComponentListAdapter(
1010
private val layoutInflater: LayoutInflater,

android/app/src/main/java/com/sample/component/ComponentViewModel.kt renamed to android/app/src/main/java/com/react/testapp/component/ComponentViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.sample.component
1+
package com.react.testapp.component
22

33
data class ComponentViewModel(
44
val name: String,

android/app/src/main/java/com/sample/di/ActivityScope.kt renamed to android/app/src/main/java/com/react/testapp/di/ActivityScope.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.sample.di
1+
package com.react.testapp.di
22

33
import javax.inject.Scope
44

0 commit comments

Comments
 (0)