Add download all and all namespaces flags #1917
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snguyen64
requested changes
Oct 24, 2025
| downloadServices := make(map[string]*DownloadService) | ||
|
|
||
| // Collect all files in memory | ||
| allFiles := make(map[string][]byte) |
There was a problem hiding this comment.
Would this cause memory issues?
If captures files are large and there are multiple in different namespaces
| if downloadAllNamespaces { | ||
| fmt.Println("Downloading all captures from all namespaces...") | ||
| } else { | ||
| fmt.Println("Downloading all captures...") |
There was a problem hiding this comment.
nit - add 'for namespace x' here
| return nil | ||
| } | ||
|
|
||
| func downloadAllCaptures(ctx context.Context, config *rest.Config, namespace string) error { |
There was a problem hiding this comment.
nit:
recommend breaking this down into a couple functions,
| } | ||
|
|
||
| // Create the final archive | ||
| timestamp := time.Now().Format("20060102150405") |
There was a problem hiding this comment.
looks like a magic number - there should be constant for this in the time package
|
|
||
| downloadCapture.Flags().StringVar(&blobURL, "blob-url", "", "Blob URL from which to download") | ||
| downloadCapture.Flags().StringVar(&captureName, "name", "", "The name of a the capture") | ||
| downloadCapture.Flags().BoolVar(&downloadAll, "all", false, "Download all available captures") |
There was a problem hiding this comment.
this is a bit unclear but looks like this is download all for specific namespace
We should clarify that so it's apparent the different between all and all-namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow user to download all captures from a specific namespace or from all namespaces
Related Issue
#1836
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.