Temp fix for linux and mac sql server 2025 image (#19918) (#19976)

* temp fix for linux and mac sql server 2025 image

* check for arm mac

* added latest to string; remove uneccessary state updates in form validation

* fix broken test

* pr comments

---------

Co-authored-by: Lauren Nathan <[email protected]>

Author: laurenastrid1

src/containerDeployment/containerDeploymentWebviewController.ts

@@ -97,14 +97,12 @@ export class ContainerDeploymentWebviewController extends FormWebviewController<
     private registerRpcHandlers() {
         this.registerReducer("formAction", async (state, payload) => {
             (state.formState as any)[payload.event.propertyName] = payload.event.value;
-            this.updateState(state);
 
             const newState = await this.validateDockerConnectionProfile(
                 state,
                 this.state.formState,
                 payload.event.propertyName,
             );
-            this.updateState(newState);
             return newState;
         });
         this.registerReducer("completeDockerStep", async (state, payload) => {

src/containerDeployment/dockerUtils.ts

@@ -86,15 +86,15 @@ export const COMMANDS = {
     GET_CONTAINERS: `docker ps -a --format "{{.ID}}"`,
     GET_CONTAINERS_BY_NAME: `docker ps -a --format "{{.Names}}"`,
     INSPECT: (id: string) => `docker inspect ${id}`,
-    PULL_IMAGE: (version: string) => `docker pull mcr.microsoft.com/mssql/server:${version}-latest`,
+    PULL_IMAGE: (versionTag: string) => `docker pull mcr.microsoft.com/mssql/server:${versionTag}`,
     START_SQL_SERVER: (
         name: string,
         password: string,
         port: number,
-        version: string,
+        versionTag: string,
         hostname: string,
     ) =>
-        `docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=${password}" -p ${port}:${defaultPortNumber} --name ${name} ${hostname ? `--hostname ${sanitizeContainerInput(hostname)}` : ""} -d mcr.microsoft.com/mssql/server:${version}-latest`,
+        `docker run -e "ACCEPT_EULA=Y" -e "SA_PASSWORD=${password}" -p ${port}:${defaultPortNumber} --name ${name} ${hostname ? `--hostname ${sanitizeContainerInput(hostname)}` : ""} -d mcr.microsoft.com/mssql/server:${versionTag}`,
     CHECK_CONTAINER_RUNNING: (name: string) =>
         `docker ps --filter "name=${sanitizeContainerInput(name)}" --filter "status=running" --format "{{.Names}}"`,
     VALIDATE_CONTAINER_NAME: 'docker ps -a --format "{{.Names}}"',
@@ -380,12 +380,25 @@ export async function getDockerPath(executable: string): Promise<string> {
     return "";
 }
 
+/**
+ * Temp fix for the SQL Server 2025 version issue on Mac.
+ * Returns the last working version of SQL Server 2025 for Mac.
+ */
+export function constructVersionTag(version: string): string {
+    let versionYear = version.substring(0, yearStringLength);
+    // Hard Coded until this issue is fixed for mac: https://github.com/microsoft/mssql-docker/issues/940#issue
+    if (platform() === Platform.Mac && arch() !== x64 && versionYear === "2025") {
+        return "2025-CTP2.0-ubuntu-22.04"; // Last working version of SQL Server 2025 for Mac
+    }
+    return `${versionYear}-latest`;
+}
+
 /**
  * Pulls the SQL Server container image for the specified version.
  */
 export async function pullSqlServerContainerImage(version: string): Promise<DockerCommandParams> {
     try {
-        await execCommand(COMMANDS.PULL_IMAGE(version.substring(0, yearStringLength)));
+        await execCommand(COMMANDS.PULL_IMAGE(constructVersionTag(version)));
         return { success: true };
     } catch (e) {
         return {
@@ -410,7 +423,7 @@ export async function startSqlServerDockerContainer(
         containerName,
         password,
         port,
-        version.substring(0, yearStringLength),
+        constructVersionTag(version),
         hostname,
     );
     try {

test/unit/containerDeploymentWebviewController.test.ts

@@ -293,7 +293,6 @@ suite("ContainerDeploymentWebviewController", () => {
             controller as any,
             "validateDockerConnectionProfile",
         );
-        const updateStateSpy = sandbox.spy(controller as any, "updateState");
 
         const callState = controller["state"];
 
@@ -306,11 +305,6 @@ suite("ContainerDeploymentWebviewController", () => {
         });
 
         assert.ok(validateProfileSpy.calledOnce, "profile validation should be called once");
-        assert.ok(
-            updateStateSpy.calledTwice,
-            "updateState should be called once within formAction",
-        );
-
         assert.equal(newState.isValidContainerName, true);
     });