WIP: working on tests.

Author: mikebronner

database/seeders/OwnedBySeeder.php

@@ -4,6 +4,7 @@
 
 namespace GeneaLabs\LaravelGovernor\Database\Seeders;
 
+use GeneaLabs\LaravelGovernor\Policies\BasePolicy;
 use GeneaLabs\LaravelGovernor\Traits\EntityManagement;
 use GeneaLabs\LaravelGovernor\Traits\GovernorOwnedByField;
 use Illuminate\Database\Seeder;
@@ -17,7 +18,7 @@ public function run()
     {
         $this->getPolicies()
             ->each(function ($policy) {
-                if (! is_subclass_of($policy, BasePolicy::class)) {
+                if (! collect(class_parents($policy))->contains(BasePolicy::class)) {
                     return collect();
                 }
 

phpunit.xml

@@ -1,5 +1,16 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" backupStaticAttributes="false" bootstrap="vendor/autoload.php" colors="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    backupGlobals="false"
+    backupStaticAttributes="false"
+    bootstrap="vendor/autoload.php"
+    colors="true"
+    convertErrorsToExceptions="true"
+    convertNoticesToExceptions="true"
+    convertWarningsToExceptions="true"
+    processIsolation="false"
+    stopOnFailure="true"
+    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+>
   <coverage processUncoveredFiles="true">
     <include>
       <directory suffix=".php">./src</directory>

src/Http/Middleware/ParseCustomPolicyActions.php

@@ -28,7 +28,7 @@ protected function registerCustomPolicyActions(): void
         $this
             ->getPolicies()
             ->map(function (string $policyClass, string $modelClass): Collection {
-                if (! is_subclass_of($policyClass, BasePolicy::class)) {
+                if (! collect(class_parents($policyClass))->contains(BasePolicy::class)) {
                     return collect();
                 }
 

src/Policies/BasePolicy.php

@@ -122,7 +122,7 @@ protected function validatePermissions(
             $user = $this->createGuestUser();
         }
 
-        $user->loadMissing("roles", "teams.permision");
+        $user->loadMissing("roles", "teams.permissions");
 
         if ($user->hasRole("SuperAdmin")) {
             return true;

tests/Integration/Policies/BasePolicyTest.php

@@ -1,4 +1,8 @@
-<?php namespace GeneaLabs\LaravelGovernor\Tests\Integration\Policies;
+<?php
+
+declare(strict_types=1);
+
+namespace GeneaLabs\LaravelGovernor\Tests\Integration\Policies;
 
 use GeneaLabs\LaravelGovernor\Permission;
 use GeneaLabs\LaravelGovernor\Team;