add pyflakes check (#451)

Author: balamurugana

.travis.yml

@@ -14,9 +14,10 @@ env:
 - ARCH=i686
 
 install:
-- pip install urllib3 certifi pytz
+- pip install urllib3 certifi pytz pyflakes
 
 script:
+- pyflakes minio/*.py || true
 - python setup.py install
 - python setup.py nosetests
 

minio/api.py

@@ -41,7 +41,6 @@
 # Dependencies
 import urllib3
 import certifi
-import pytz
 
 # Internal imports
 from . import __title__, __version__
@@ -372,7 +371,7 @@ def set_bucket_policy(self, bucket_name, prefix, policy_access):
             self._url_open("PUT",
                            bucket_name=bucket_name,
                            query={"policy": ""},
-                           headers={},
+                           headers=headers,
                            body=content,
                            content_sha256=content_sha256_hex)
 
@@ -463,10 +462,10 @@ def listen_bucket_notification(self, bucket_name, prefix, suffix, events):
 
         url_components = urlsplit(self._endpoint_url)
         if url_components.hostname == 's3.amazonaws.com':
-            raise InvalidArgumentErr('Listening for event notifications on a'
-                                     ' bucket is a Minio specific extension to'
-                                     ' bucket notification API. It is not'
-                                     ' supported by Amazon S3')
+            raise InvalidArgumentError(
+                'Listening for event notifications on a  bucket is a Minio '
+                'specific extension to bucket notification API. It is not '
+                'supported by Amazon S3')
 
         query = {
             'prefix': prefix,
@@ -601,11 +600,6 @@ def fput_object(self, bucket_name, object_name, file_path,
                         total_uploaded += previous_part.size
                         continue
 
-            # Save hexlified sha256.
-            part_sha256_hex = sha256hasher.hexdigest()
-            # Save base64 md5sum.
-            part_md5_base64 = md5hasher.base64digest()
-
             # Seek back to previous offset position before checksum
             # calculation.
             file_data.seek(prev_offset, 0)

minio/compat.py

@@ -27,39 +27,56 @@
 
 import sys
 
-# -------
-# Pythons
-# -------
-
-# Syntax sugar.
-_ver = sys.version_info
-
 #: Python 2.x?
-is_py2 = (_ver[0] == 2)
+_is_py2 = (sys.version_info[0] == 2)
 
 #: Python 3.x?
-is_py3 = (_ver[0] == 3)
+_is_py3 = (sys.version_info[0] == 3)
 
-if is_py2:
-    from urllib import pathname2url as urlencode
-    from urllib import url2pathname as urldecode
-    from urlparse import urlsplit, parse_qs
+if _is_py2:
+    from urllib import pathname2url
+    urlencode = pathname2url
 
-    builtin_str = str
+    from urllib import url2pathname
+    urldecode = url2pathname
+
+    import urlparse
+    urlsplit = urlparse.urlsplit
+    parse_qs = urlparse.parse_qs
+
+    ## Create missing types.
     bytes = str
+
+    ## Update better types.
+    builtin_range = range
+    range = xrange
+    builtin_str = str
     str = unicode
+
+    ## Add missing imports
     basestring = basestring
-    numeric_types = (int, long, float)
-    range = xrange
+elif _is_py3:
+    from urllib.request import pathname2url
+    urlencode = pathname2url
+
+    from urllib.request import url2pathname
+    urldecode = url2pathname
 
-elif is_py3:
-    from urllib.request import pathname2url as urlencode
-    from urllib.request import url2pathname as urldecode
-    from urllib.parse import urlsplit, parse_qs
+    import urllib.parse
+    urlsplit = urllib.parse.urlsplit
+    parse_qs = urllib.parse.parse_qs
 
+    ## Create types to compat with py2.
+    builtin_range = range
     builtin_str = str
-    str = str
-    bytes = bytes
+
+    ## Create missing types.
     basestring = (str, bytes)
-    numeric_types = (int, float)
+    long = int
+
+    ## Add missing imports
+    bytes = bytes
     range = range
+    str = str
+
+numeric_types = (int, long, float)

minio/copy_conditions.py

@@ -25,7 +25,7 @@
 """
 
 import collections
-from .helpers import (is_non_empty_string, is_valid_bucket_name)
+from .helpers import is_non_empty_string
 
 # CopyCondition explanation:
 # http://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectCOPY.html

minio/signer.py

@@ -28,11 +28,10 @@
 import collections
 import hashlib
 import hmac
-import binascii
 
 from datetime import datetime
 from .error import InvalidArgumentError
-from .compat import urlsplit, parse_qs, basestring, urlencode
+from .compat import urlsplit, urlencode
 from .helpers import (ignore_headers, get_sha256_hexdigest)
 
 # Signature version '4' algorithm.
@@ -158,7 +157,6 @@ def get_signed_headers(headers):
 
     :param headers: input dictionary to be sorted.
     """
-    headers_to_sign = dict(headers)
     signed_headers = []
     for header in headers:
         signed_headers.append(header.lower().strip())

tests/unit/minio_mocks.py

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
-# Minio Python Library for Amazon S3 Compatible Cloud Storage, (C) 2015 Minio, Inc.
+# Minio Python Library for Amazon S3 Compatible Cloud Storage,
+# (C) 2015,2016 Minio, Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -13,9 +14,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from minio.compat import is_py3
+from minio.compat import _is_py3
 
-if is_py3:
+if _is_py3:
     import http.client as httplib
 else:
     import httplib