Skip to content

Commit e108b9b

Browse files
committed
Bump up version to 2.2.5
1 parent 058d6c9 commit e108b9b

File tree

4 files changed

+68
-37
lines changed

4 files changed

+68
-37
lines changed

MAINTAINERS.md

Lines changed: 49 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,41 @@
11
# For maintainers only
22

33
## Responsibilities
4-
54
Please go through this link [Maintainer Responsibility](https://gist.github.com/abperiasamy/f4d9b31d3186bbd26522)
65

76
### Setup your minio-py Github Repository
8-
97
Fork [minio-py upstream](https://github.com/minio/minio-py/fork) source repository to your own personal repository.
10-
```bash
11-
$ git clone https://github.com/$USER_ID/minio-py
8+
```sh
9+
$ git clone git@github.com:minio/minio-py
1210
$ cd minio-py
11+
$ pip install urllib3 certifi pytz pyflakes faker twine
12+
```
13+
14+
### Modify package version
15+
```sh
16+
$ cat minio/__init__.py
17+
...
18+
...
19+
__version__ = '2.2.5'
20+
...
21+
...
22+
23+
```
24+
25+
### Build and verify
26+
Run `./tests/unit_test.sh` and `./tests/functional_test.sh` to verify the SDK.
27+
```sh
28+
$ ./tests/unit_test.sh
29+
$ ./tests/functional_test.sh all
30+
$ python setup.py sdist bdist bdist_wheel
1331
```
1432

1533
### Publishing new packages
1634

1735
#### Setup your pypirc
18-
1936
Create a new `pypirc`
2037

21-
```bash
38+
```sh
2239
$ cat >> $HOME/.pypirc << EOF
2340
[distutils]
2441
index-servers =
@@ -31,20 +48,34 @@ EOF
3148

3249
```
3350

34-
#### Modify version
51+
#### Sign
52+
Sign the release artifacts, this step requires you to have access to Minio's trusted private key.
53+
```sh
54+
$ export GNUPGHOME=/media/${USER}/minio/trusted
55+
$ gpg --detach-sign -a dist/minio-2.2.5.tar.gz
56+
$ gpg --detach-sign -a dist/minio-2.2.5.linux-x86_64.tar.gz
57+
$ gpg --detach-sign -a dist/minio-2.2.5-py2.py3-none-any.whl
58+
```
3559

36-
```bash
37-
$ cat minio/__init__.py
38-
...
39-
...
40-
__version__ = '0.3.0'
41-
...
42-
...
60+
#### Upload to pypi
61+
Upload the signed release artifacts, please install twine v1.8.0+ for following steps to work properly.
62+
```sh
63+
$ twine upload dist/*
64+
```
4365

66+
### Tag
67+
Tag and sign your release commit, additionally this step requires you to have access to Minio's trusted private key.
68+
```
69+
$ export GNUPGHOME=/media/${USER}/minio/trusted
70+
$ git tag -s 2.2.5
71+
$ git push
72+
$ git push --tags
4473
```
4574

46-
#### Upload to pypi
75+
### Announce
76+
Announce new release by adding release notes at https://github.com/minio/minio-java/releases from `[email protected]` account. Release notes requires two sections `highlights` and `changelog`. Highlights is a bulleted list of salient features in this release and Changelog contains list of all commits since the last release.
4777

48-
```bash
49-
$ python setup.py sdist bdist bdist_wheel upload
50-
```
78+
To generate `changelog`
79+
```sh
80+
git log --no-color --pretty=format:'-%d %s (%cr) <%an>' <last_release_tag>..<latest_release_tag>
81+
```

minio/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
__title__ = 'minio-py'
3131
__author__ = 'Minio, Inc.'
32-
__version__ = '2.2.4'
32+
__version__ = '2.2.5'
3333
__license__ = 'Apache 2.0'
3434
__copyright__ = 'Copyright 2015, 2016, 2017 Minio, Inc.'
3535

tests/functional_test.sh

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,38 +22,38 @@ build() {
2222
echo "building..."
2323
cd ../
2424
if [[ $py2flag = 1 ]]; then
25-
sudo python setup.py install
25+
python2 setup.py install --prefix ${HOME}/.local
2626
else
27-
sudo python3 setup.py install
27+
python3 setup.py install --prefix ${HOME}/.local
2828
fi
2929
cd tests
3030
}
3131

3232
run() {
3333
echo "running..."
3434
if [[ $py2flag = 1 ]]; then
35-
python ./functional/tests.py
35+
python2 ./functional/tests.py
3636
else
37-
python3 ./functional/tests.py
38-
fi
37+
python3 ./functional/tests.py
38+
fi
3939
}
4040

4141
main () {
42-
if [[ $# -lt 1 ]]; then
43-
echo "Usage: ./functional_test.sh [py2|py3|all]"
42+
if [[ $# -lt 1 ]]; then
43+
echo "Usage: ./functional_test.sh [py2|py3|all]"
4444
fi
4545
# Build test file binary
46-
if [[ $1 == "py2" || $1 == "all" ]]; then
47-
py2flag=1
48-
echo "Running python2 tests..."
49-
build
50-
run
46+
if [[ $1 == "py2" || $1 == "all" ]]; then
47+
py2flag=1
48+
echo "Running python2 tests..."
49+
build
50+
run
5151
fi
5252
if [[ $1 == "py3" || $1 == "all" ]]; then
53-
py2flag=0
54-
echo "Running python3 tests..."
55-
build
56-
run
53+
py2flag=0
54+
echo "Running python3 tests..."
55+
build
56+
run
5757
fi
5858

5959
}

tests/unit_test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
echo "Running unit tests on python2... " && nosetests
18-
echo "Running unit tests on python3... " && nosetests3
17+
echo "Running unit tests on python2... " && python2 setup.py nosetests
18+
echo "Running unit tests on python3... " && python3 setup.py nosetests

0 commit comments

Comments
 (0)